Repository navigation
Conversation
This was referenced Oct 9, 2026
Open
Open
Open
Collaborator
Author
Collaborator
Author
|
@coderabbitai review |
Contributor
✅ Action performedReview finished.
|
JuaniRios
force-pushed
the
rai-2998-trade-price
branch
from
October 9, 2026 23:39
cea7c7e to
7618826
Compare
JuaniRios
force-pushed
the
rai-2998-board-commands
branch
from
October 10, 2026 01:15
6f1e4b7 to
74bc9ab
Compare
JuaniRios
force-pushed
the
rai-2998-trade-price
branch
from
October 10, 2026 01:15
7618826 to
0fa27ba
Compare
JuaniRios
force-pushed
the
rai-2998-board-commands
branch
from
October 10, 2026 01:58
74bc9ab to
648fe13
Compare
JuaniRios
force-pushed
the
rai-2998-trade-price
branch
2 times, most recently
from
October 10, 2026 02:39
0102b1d to
cf5a276
Compare
JuaniRios
force-pushed
the
rai-2998-board-commands
branch
from
October 10, 2026 02:39
648fe13 to
4e86ddd
Compare
JuaniRios
force-pushed
the
rai-2998-trade-price
branch
from
October 10, 2026 03:14
cf5a276 to
a85d528
Compare
JuaniRios
force-pushed
the
rai-2998-board-commands
branch
from
October 10, 2026 03:14
4e86ddd to
7261692
Compare
JuaniRios
force-pushed
the
rai-2998-trade-price
branch
from
October 10, 2026 04:11
a85d528 to
956c7ac
Compare
JuaniRios
force-pushed
the
rai-2998-board-commands
branch
from
October 10, 2026 04:11
7261692 to
7f37a41
Compare
This was referenced Oct 10, 2026
Open
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Part of RAI-3101.
The dashboard trade now carries its fill price. Item 5 of the RAI-2998 stack, part 1 of 3. This is the minimal
Trade.pricepart of #1657.Live effect: v3 trade payloads (
/tradesand the WebSocket) gain apricefield · Risk: low (older protocols keep their exact shape, and the SPA treats a missing price as null) · Ships: with the next bot releaseWhy
The
liq_tradelog line (item 5, a later PR) needs the price of each terminal trade. I took the price from #1657 without its inventory and settings DTO changes.Decisions
price: Option<Usd>. It is the onchainprice_usdc, or the broker fill price for a filled counter-trade. A failed or cancelled counter-trade hasNone, even if it kept a partial fill.terminal_outcomes_v3carries it. Legacy, v1, and v2 responses stay byte for byte the same, so an older dashboard bundle does not break.priceasnulland rejects a non-positive or non-decimal value.liq_tradeline. I kept it here so the later PR stays small. lmk if you'd rather hold this one until then.Proof
cargo nextest run -p st0x-hedge -p st0x-configpasses on the top of this stack.Merge conditions
Same as the stack below.