Repository navigation
Conversation
|
@coderabbitai full review |
✅ Action performedFull review finished. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe liquidity dashboards replace separate status and configuration panels with a dynamic header that displays connection status, deployment details, settings, and recovery guidance. A generator embeds the header assets and recovery-guide catalog in the dashboard panels. The change also adds a catalog parity test and documentation, updates navigation titles, and renumbers remaining panels. Priority: ⬇️ Low Merge Risk: 🔵 Low · up to Every liquidity board tab now uses one generated header for status, configuration, and recovery commands. The change is observability-only and deploys on merge, but it has not been confirmed on live Grafana. Owners should check that the header and recovery guide still appear when the bot stops reporting data. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 3 files. (6 skipped: 6… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
-
Check name Status Explanation Title check The title clearly summarizes the main change: adding the SPA header and recovery guide to every liquidity board tab. Description check The description directly explains the header, recovery guide, affected tabs, implementation, validation, deployment, and known verification limits. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 3 files. (6 skipped: 6 unsupported.)
- Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
-
🛠️ Fix failing CI checks 💡
-
- Commit to this branch
- Create a new PR
-
- Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
e053b94 to
23f1f68
Compare
5790b7b to
9bea021
Compare
23f1f68 to
8a30d42
Compare
|
@coderabbitai review |
|
@rain-marvin review |
✅ Action performedReview finished.
|
|
🔎 Reviewing |
![rain-marvin[bot]](https://avatars.githubusercontent.com/in/5077017?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR replaces the stat-pill row at the top of all five liquidity board tabs with one Business Text panel that ports the SPA header: the settings pills with their bands, a Config dialog, the CLI recovery guide, a UTC clock, the deployed commit, uptime, and a three-state Bot light. The generator inlines header.js, header.css and recovery-guide.json into the board JSON, and a dashboard test fails when the guide copy drifts from the SPA's RECOVERY_GUIDE. Since the last review, only the guide text changed (the resume-usdc converting note and the fail-usdc-transfer steps from #1688).
Overall read: no blockers. gen-t0-liquidity.py --check passes at this head (5 boards match), the query goes through promql() so the Source pin still applies, every value is escaped before it goes into innerHTML, and the new guide text matches the SPA strings. The earlier threads (info-row selection, drift-test scope, plugin pin, uptime while down, narrow width, source of truth, re-render, docs) are deferred by the author and I do not repeat them. Two minor points below: the header can show past state next to a live clock, and the board guide deploys on merge while the bot it describes deploys on release.
claude-opus-5-5 · high · 12 min
|
@coderabbitai approve |
✅ Action performedComments resolved and changes approved. |
|
@JuaniRios 🔔 Follow-up: a day after my review @JuaniRios, #1689 hasn't moved since my approval of claude-opus-5-5 · high · 14 min |
This branch has not been deployed
1 participant
Part of RAI-3097.
Every liquidity board tab gets the SPA header as one Business Text panel: settings pills, Config, the CLI recovery guide, the commit, uptime, and the Bot light. Item 6a of the RAI-2998 stack, part 3 of 6. Ported from #1654 and #1662.
Live effect: the header row on all five tabs · Risk: low (read-only queries, a revert undoes it) · Ships: on merge, through the
observabilityworkflowWhy
The stat pills could not show the bands, the Config dialog, or the recovery guide. The header is the first piece of #1654 that does not need the DTO changes in #1657.
Decisions
header.js,header.css, andrecovery-guide.jsonlive inobservability/liquidity-panels/, and the generator inlines them. Never edit the board JSON by hand.recovery-guide.jsonis the SPA'sRECOVERY_GUIDEin client form.dashboard/src/lib/transfer-board.test.tsfails when it drifts. Its Base to Alpacafail-usdc-transfertext is the feat: show the SPA's recovery commands for the operations client [RAI-3096] #1688 text, which follows the docs: check WithdrawV2 too before failing a Base to Alpaca USDC transfer [RAI-3125] #1704 runbook. It runs in CI inside the dashboard build (nix build .#st0x-dashboardrunsbun run test:runwith the whole repo as source).Proof
gen-t0-liquidity.py --checkpasses. The drift test fails when I change one command inrecovery-guide.jsonand passes again when I revert it.liq_settings_infolabels for a few minutes.Merge conditions
Same as the stack below. The board deploys on merge to master through the
observabilityworkflow, not with a bot release. That is safe before the bot releases:Sourcedefaults toexporter, so the published board reads the same series as today.