Repository navigation
Conversation
|
@coderabbitai full review |
✅ Action performedFull review finished. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. 5 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 8 reviews per hour. WalkthroughThe Dashboard tab replaces its former inventory views with Alpaca USD, on-chain USD by chain, and equities tables. The generator adds table rendering, percentage-bar, and status-flag helpers. The main dashboard updates its inventory queries, field formatting, and layout. The README documents chain-labelled metric availability and panel-height guidance. The Logs, Orders, Performance, and PnL tab dashboards receive sequential panel ID changes. Priority: ⬇️ Low Merge Risk: 🟡 Moderate · up to Equities Total USD can misstate holdings when a symbol has broker shares and its wrapper ratio differs from one. Correct the valuation before merging unless that discrepancy is explicitly accepted. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 64.29% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 14 functions across 1 files. (2 skipped: … | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly and concisely identifies the main change: showing the liquidity inventory as per-chain Grafana tables. |
| Description check | |
The description directly explains the dashboard table changes, query behavior, risks, validation, and deployment conditions. |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Docstring Coverage
Explanation
Docstring coverage is 64.29% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 14 functions across 1 files. (2 skipped: 2 unsupported.)
- Fix all pre-merge checks with AI
✨ Finishing Touches 💡 2
📝 Generate docstrings 💡
- Commit to this branch
- Create a new PR
🛠️ Fix failing CI checks 💡
- Commit to this branch
- Create a new PR
- Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
✅ Action performedComments resolved and changes approved. |
34aa195 to
81cb2d2
Compare
372a865 to
f8aa8c6
Compare
7829221 to
e053b94
Compare
4d0d5f8 to
de89581
Compare
e053b94 to
23f1f68
Compare
23f1f68 to
8a30d42
Compare
de89581 to
150fc94
Compare
This branch has not been deployed
1 participant
Part of RAI-3098.
The Dashboard tab's inventory becomes three Grafana tables: USD · Alpaca, USD · Onchain with a row per chain, and Equities with a column per chain. Item 6a of the RAI-2998 stack, part 4 of 6. Ported from #1654.
Live effect: the inventory on the Dashboard tab · Risk: low (read-only queries, a revert undoes it) · Ships: on merge, through the
observabilityworkflowWhy
Production hedges on Base and Robinhood, and the old tables show one chain. The tables also get column filters.
Decisions
liq_usdc_chain_*,liq_usdc_corridor_*,liq_equity_chain_available). OnSource = exporterthose are absent, and each falls back to the unlabelled Base series, as feat: SPA layout as Grafana tables on the liquidity board #1654 designed. The fallback is per source, not per row: while the bot publishes per-chain series, a chain without a labelled value shows none. gen-t0-liquidity.pyΔcolumns are gone, so the board no longer readsliq_equity_ratio_deviationorliq_usdc_ratio_deviation. That is whycompare.pydrops them (RAI-3034). I checked: no board query names them now.Risks
target_shareis still judged against the default target when no other chain vault holds it. Only DNUT overrides it today. DNUT is multi-chain, so it is grey while another chain vault holds DNUT, but it gets a wrong verdict if those vaults are empty.Proof
gen-t0-liquidity.py --checkpasses. The panel heights are feat: SPA layout as Grafana tables on the liquidity board #1654's, checked on its preview board for windows of 18 to 45 rows.--check, pins which colour each bar cell draws. gen-t0-liquidity.pyorfallback on both sources. Each side goes throughmax by (venue)ormax by (symbol, col), so no duplicate rows.Merge conditions
Same as the stack below. The board deploys on merge to master through the
observabilityworkflow, not with a bot release. That is safe before the bot releases:Sourcedefaults toexporter, so the published board reads the same series as today. The Equities Ratio bars show grey on that source.