Remove forbidden `@author` tag from `Magento_Review` by fredden · Pull Request #36977 · magento/magento2

fredden · 2023-03-06T18:03:19Z

Description

According to https://devdocs.magento.com/guides/v2.4/coding-standards/docblock-standard-general.html#documentation-space, the @author tag is not permitted in Magento. This pull request removes this tag from the Magento_Review module. Given there are so many instances of this tag, I've opened a small pull request to get the process started. I expect that the linter will force me to fix several other coding standards violations on the way, so having a smaller pull request means that task is easier to manage. I plan to open more pull requests to tackle the other instances of this tag.

See also magento/magento-coding-standard#382 and magento/magento-coding-standard#167

Manual testing scenarios

There are not code changes in this pull request. This pull request only removes forbidden comments.

Contribution checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Remove forbidden @author tag from Magento_Review #37277: Remove forbidden @author tag from Magento_Review

m2-assistant · 2023-03-06T18:03:22Z

Hi @fredden. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

magento-automated-testing · 2023-03-06T18:03:37Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2023-03-07T17:28:13Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

…view

magento-automated-testing · 2023-03-14T17:17:01Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2023-03-14T21:54:05Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

leonhelmus

Looks good to me!

leonhelmus · 2023-03-20T08:37:16Z

app/code/Magento/Review/Model/ResourceModel/Rating/Collection.php

            foreach ($data as $row) {
                $item = $this->getItemById($row['rating_id']);
-                $item->setStores(array_merge($item->getStores(), [$row['store_id']]));
+                $stores = $item->getStores();


@fredden This seems Like a good change maybe add it in the desciption of the pull request.

magento-automated-testing · 2023-03-21T10:17:09Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Delta · 2023-03-24T06:55:40Z

@magento run all tests

magento-automated-testing · 2023-03-24T06:55:46Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Delta · 2023-03-24T09:49:30Z

@magento run all tests

magento-automated-testing · 2023-03-24T09:49:41Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Delta · 2023-03-25T06:50:34Z

@magento run Functional Tests B2B, Functional Tests CE,Functional Tests EE

magento-automated-testing · 2023-03-25T06:50:44Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Delta · 2023-03-27T05:22:58Z

@magento run Functional Tests B2B, Functional Tests CE,Functional Tests EE

magento-automated-testing · 2023-03-27T05:23:04Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2023-03-27T09:37:40Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Delta · 2023-03-27T13:41:30Z

Unit Test failure is not related to the PR changes
Functional Tests B2B and CE failures are different on last two run
Functional B2B : run 1

run 2

Functional CE : run 1

run 2

engcom-Echo · 2023-09-21T06:17:37Z

@magento run all tests

magento-automated-testing · 2023-09-21T06:17:43Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Echo · 2023-09-21T08:10:21Z

@magento run Integration Tests,Functional Tests CE,Functional Tests EE,Functional Tests B2B

magento-automated-testing · 2023-09-21T08:10:32Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Echo · 2023-09-21T10:19:42Z

Functional Tests EE,Functional Tests CE,Functional Tests B2B failures are different on last two run.
Functional Tests EE
Run1

Run2

Functional Tests CE
Run1

Run2

Functional Tests B2B
Run1

Run2

Hence moving it to merge in progress

Remove forbidden @author tag

c40c686

m2-github-services added Partner: Fisheye partners-contribution Pull Request is created by Magento Partner labels Mar 6, 2023

Fix static tests

dda20f5

fredden added 2 commits March 14, 2023 17:01

Merge remote-tracking branch 'upstream/2.4-develop' into no-author/re…

414b090

…view

Fix static test failures

7606dd0

leonhelmus approved these changes Mar 20, 2023

View reviewed changes

m2-community-project bot assigned leonhelmus Mar 20, 2023

m2-community-project bot added the Progress: ready for testing label Mar 20, 2023

This was referenced Mar 20, 2023

[Issue] Remove forbidden @author tag from Magento_Wishlist #37243

Closed

[Issue] Remove forbidden @author tag from Magento_Backup and Magento_Bundle #37244

Closed

m2-community-project bot added Progress: extended testing and removed Progress: testing in progress labels Mar 21, 2023

engcom-Delta self-assigned this Mar 22, 2023

m2-community-project bot added Progress: ready for testing Progress: extended testing and removed Progress: extended testing Progress: ready for testing labels Mar 22, 2023

PR:36977 fix for static test failures

5b59ad3

fix for static test failure

cfae994

Merge branch '2.4-develop' into no-author/review

2829610

m2-community-project bot added Progress: accept and removed Progress: extended testing labels Sep 21, 2023

magento-devops-reposync-svc merged commit 3ef65e4 into magento:2.4-develop Oct 5, 2023

fredden deleted the no-author/review branch October 5, 2023 09:26

Conversation

fredden commented Mar 6, 2023 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Manual testing scenarios

Contribution checklist

Resolved issues:

Uh oh!

m2-assistant bot commented Mar 6, 2023

Uh oh!

magento-automated-testing bot commented Mar 6, 2023

Uh oh!

magento-automated-testing bot commented Mar 7, 2023

Uh oh!

magento-automated-testing bot commented Mar 14, 2023

Uh oh!

magento-automated-testing bot commented Mar 14, 2023

Uh oh!

leonhelmus left a comment

Choose a reason for hiding this comment

Uh oh!

leonhelmus Mar 20, 2023

Choose a reason for hiding this comment

Uh oh!

magento-automated-testing bot commented Mar 21, 2023

Uh oh!

engcom-Delta commented Mar 24, 2023

Uh oh!

magento-automated-testing bot commented Mar 24, 2023

Uh oh!

engcom-Delta commented Mar 24, 2023

Uh oh!

magento-automated-testing bot commented Mar 24, 2023

Uh oh!

engcom-Delta commented Mar 25, 2023

Uh oh!

magento-automated-testing bot commented Mar 25, 2023

Uh oh!

engcom-Delta commented Mar 27, 2023

Uh oh!

magento-automated-testing bot commented Mar 27, 2023

Uh oh!

magento-automated-testing bot commented Mar 27, 2023

Uh oh!

engcom-Delta commented Mar 27, 2023

Uh oh!

engcom-Echo commented Sep 21, 2023

Uh oh!

magento-automated-testing bot commented Sep 21, 2023

Uh oh!

engcom-Echo commented Sep 21, 2023

Uh oh!

magento-automated-testing bot commented Sep 21, 2023

Uh oh!

engcom-Echo commented Sep 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

fredden commented Mar 6, 2023 •

edited by m2-assistant bot

Loading