Remove forbidden `@author` tag from `Magento_Backup` and `Magento_Bundle` by fredden · Pull Request #36979 · magento/magento2

fredden · 2023-03-06T22:31:06Z

Description

According to https://devdocs.magento.com/guides/v2.4/coding-standards/docblock-standard-general.html#documentation-space, the @author tag is not permitted in Magento. This pull request removes this tag from the Magento_Backup and Magento_Bundle modules. Given there are so many instances of this tag, I've opened a small pull request to get the process started. I expect that the linter will force me to fix several other coding standards violations on the way, so having a smaller pull request means that task is easier to manage. I plan to open more pull requests to tackle the other instances of this tag.

See also magento/magento-coding-standard#382 and magento/magento-coding-standard#167

Manual testing scenarios

There are not code changes in this pull request. This pull request only removes forbidden comments.

Contribution checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Remove forbidden @author tag from Magento_Backup and Magento_Bundle #37244: Remove forbidden @author tag from Magento_Backup and Magento_Bundle

m2-assistant · 2023-03-06T22:31:09Z

Hi @fredden. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

magento-automated-testing · 2023-03-06T22:31:26Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

…ckup-bundle

magento-automated-testing · 2023-03-14T17:34:05Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2023-03-14T21:55:21Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

leonhelmus

Looks good to me!

leonhelmus · 2023-03-20T08:51:00Z

@magento create issue

engcom-Charlie · 2024-06-11T07:05:17Z

@magento run all tests

engcom-Charlie · 2024-06-11T09:40:01Z

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, WebAPI Tests

engcom-Charlie · 2024-06-12T07:31:42Z

Implemented a fix for SVC failure.

engcom-Charlie · 2024-06-12T07:32:57Z

@magento run all tests

engcom-Charlie · 2024-06-12T09:49:18Z

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, WebAPI Tests

engcom-Charlie · 2024-06-13T12:02:22Z

Few of the functional B2B, CE, EE and WebAPI failures are different in latest 2 build results, seems to be flaky and the consistent one in both the builds are known issues. Hence moving this PR to Merge in Progress.

Functional B2B: Run 1:

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36979/148f512f36a61c01b8e56b958c25362b/Functional/allure-report-b2b/index.html

Known issues:

#ACQE-6695: TierPricingWhenPriceScopeIsWebsiteWorkingProperlyWithMultipleCurrenciesConfiguredTest
#ACQE-6523: AdminReorderWithCatalogPriceRuleDiscountTest
#ACQE-6648: StorefrontUpdateCustomerAddressBelgiumTest

Functional CE: Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36979/aa0f4e0a9cd25dbb487c4d8746bc2b03/Functional/allure-report-ce/index.html#categories/b9b96e4c148bf2a52e53da9c81ddc455/de6c7fb1c5b52ad5/

RUN 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36979/aa0f4e0a9cd25dbb487c4d8746bc2b03/Functional/allure-report-ce/index.html

Known issues:

#ACQE-6695: TierPricingWhenPriceScopeIsWebsiteWorkingProperlyWithMultipleCurrenciesConfiguredTest
#ACQE-6648: StorefrontUpdateCustomerAddressBelgiumTest
#ACQE-6694: AdminCreateOrderWithCustomerWithoutEmailTest

Functional EE: Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36979/a6cf00971914c2a2e4d36c150068b120/Functional/allure-report-ee/index.html#categories

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36979/14934a70ba689764578b58db55e96ec1/Functional/allure-report-ee/index.html

Known issues:

#ACQE-6331: StorefrontCreateOrderAllQuantityGroupedProductOptionDefaultStockTest
#ACQE-6694: AdminCreateOrderWithCustomerWithoutEmailTest
#ACQE-6695: TierPricingWhenPriceScopeIsWebsiteWorkingProperlyWithMultipleCurrenciesConfiguredTest

Web API test: Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36979/d518417961eb4ee4c5aa4292009a34c6/WebApi/console-error-logs.html

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36979/8f5c1de688dfd903236449dc041581d2/WebApi/console-error-logs.html

engcom-Dash · 2025-08-05T08:41:29Z

@magento run all tests

Remove forbidden @author tag

a68ec0c

m2-github-services added Partner: Fisheye partners-contribution Pull Request is created by Magento Partner labels Mar 6, 2023

fredden added 2 commits March 14, 2023 17:24

Merge remote-tracking branch 'upstream/2.4-develop' into no-author/ba…

993b014

…ckup-bundle

Fix static test failures

2b10dd5

leonhelmus approved these changes Mar 20, 2023

View reviewed changes

m2-community-project bot assigned leonhelmus Mar 20, 2023

m2-community-project bot added the Progress: ready for testing label Mar 20, 2023

m2-assistant bot mentioned this pull request Mar 20, 2023

[Issue] Remove forbidden @author tag from Magento_Backup and Magento_Bundle #37244

Closed

5 tasks

Merge branch '2.4-develop' into no-author/backup-bundle

86c81af

This was referenced Mar 20, 2023

[Issue] Remove forbidden @author tag #37245

Closed

[Issue] Remove forbidden @author tag from Magento_Catalog (part 1) #37246

Closed

[Issue] Remove forbidden @author tag from Magento_Catalog (part 2) #37247

Open

m2-community-project bot added Progress: accept Progress: extended testing and removed Progress: testing in progress Progress: accept labels Apr 4, 2023

Merge branch '2.4-develop' into no-author/backup-bundle

95c72b7

Updated the code to take care SVC and static test failures

2faf86a

engcom-Charlie self-assigned this Jun 12, 2024

m2-community-project bot added Progress: ready for testing Progress: extended testing and removed Progress: extended testing Progress: ready for testing labels Jun 12, 2024

Merge branch '2.4-develop' into no-author/backup-bundle

4d1dbec

m2-community-project bot added Progress: accept and removed Progress: extended testing labels Jun 13, 2024

Merge branch '2.4-develop' into no-author/backup-bundle

2fea48a

engcom-Dash self-assigned this Aug 5, 2025

engcom-Dash moved this from Merge in Progress to Extended Testing (optional) in Pull Requests Dashboard Aug 5, 2025

ct-prd-projects-boards-automation bot added the Progress: extended testing label Aug 5, 2025

engcom-Dash moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Aug 5, 2025

ct-prd-projects-boards-automation bot removed the Progress: extended testing label Aug 5, 2025

magento-devops-reposync-svc merged commit 6b275b3 into magento:2.4-develop Aug 11, 2025
11 of 12 checks passed

ct-prd-projects-boards-automation bot moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Aug 11, 2025

fredden deleted the no-author/backup-bundle branch August 29, 2025 20:56

Conversation

fredden commented Mar 6, 2023 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Manual testing scenarios

Contribution checklist

Resolved issues:

Uh oh!

m2-assistant bot commented Mar 6, 2023

Uh oh!

magento-automated-testing bot commented Mar 6, 2023

Uh oh!

magento-automated-testing bot commented Mar 14, 2023

Uh oh!

magento-automated-testing bot commented Mar 14, 2023

Uh oh!

leonhelmus left a comment

Choose a reason for hiding this comment

Uh oh!

leonhelmus commented Mar 20, 2023

Uh oh!

engcom-Charlie commented Jun 11, 2024

Uh oh!

engcom-Charlie commented Jun 11, 2024

Uh oh!

engcom-Charlie commented Jun 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

engcom-Charlie commented Jun 12, 2024

Uh oh!

engcom-Charlie commented Jun 12, 2024

Uh oh!

engcom-Charlie commented Jun 13, 2024

Uh oh!

engcom-Dash commented Aug 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

fredden commented Mar 6, 2023 •

edited by m2-assistant bot

Loading

engcom-Charlie commented Jun 12, 2024 •

edited

Loading