Remove forbidden @author tag from Magento_Catalog* (part 5) and Magento_Checkout#36991
Remove forbidden @author tag from Magento_Catalog* (part 5) and Magento_Checkout#36991fredden wants to merge 8 commits intomagento:2.4-developfrom
@author tag from Magento_Catalog* (part 5) and Magento_Checkout#36991Conversation
|
Hi @fredden. Thank you for your contribution! Add the comment under your pull request to deploy test or vanilla Magento instance:
❗ Automated tests can be triggered manually with an appropriate comment:
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
m2-github-services
added
Partner: Fisheye
partners-contribution
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
1 similar comment
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
| if (!empty($ninProductIds)) { | ||
| $collection->addExcludeProductFilter($ninProductIds); | ||
| } | ||
| $collection->addExcludeProductFilter($ninProductIds); |
There was a problem hiding this comment.
This seems to be a fix that should not have been added here.
There was a problem hiding this comment.
In the Adobe "Static Tests" check (https://github.com/magento/magento2/runs/11822411725), PHPStan reported:
------ --------------------------------------------------------------------
Line app/code/Magento/Checkout/Block/Cart/Crosssell.php
------ --------------------------------------------------------------------
135 Variable $ninProductIds in empty() always exists and is not falsy.
------ --------------------------------------------------------------------
To avoid the test failure, I adjusted the code to be more sensible.
m2-community-project
bot
added
Progress: review
and removed
Progress: needs update
labels
ihor-sviziev
added
the
Priority: P2
|
Adding the same priority as #36976 (comment) |
|
@magento run all tests |
4 participants
Description
According to https://devdocs.magento.com/guides/v2.4/coding-standards/docblock-standard-general.html#documentation-space, the
@authortag is not permitted in Magento. This pull request removes this tag from (some of) theMagento_Catalogmodule and related andMagento_Checkout. Given there are so many instances of this tag, I've opened a small pull request to get the process started. I expect that the linter will force me to fix several other coding standards violations on the way, so having a smaller pull request means that task is easier to manage. I plan to open more pull requests to tackle the other instances of this tag.See also magento/magento-coding-standard#382 and magento/magento-coding-standard#167
See also #36304, #36976, #36977, #36978, #36979, #36980, #36981, #36987, #36988, #36989,
#36990
Manual testing scenarios
There are not code changes in this pull request. This pull request only removes forbidden comments.
Contribution checklist