Remove forbidden @author tag from Magento_Catalog (part 1)#36987
Remove forbidden @author tag from Magento_Catalog (part 1)#36987magento-devops-reposync-svc merged 7 commits intomagento:2.4-developfrom
@author tag from Magento_Catalog (part 1)#36987Conversation
|
Hi @fredden. Thank you for your contribution! Add the comment under your pull request to deploy test or vanilla Magento instance:
❗ Automated tests can be triggered manually with an appropriate comment:
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
1 similar comment
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
|
@magento create issue |
|
@magento run all tests |
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
|
@magento run all tests |
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
|
✔️ QA Passed Preconditions:
Manual testing scenario:
Before: ✖️ No addiitional manual test cases is required for the regression as this PR related to the removal of the @author tag from the Multiple builds are failing hence, moving this PR to Extended Testing |
|
@magento run all tests |
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
1 similar comment
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
|
All the builds are green , Hence moving this PR to Merge in progress Thanks |




Description
According to https://devdocs.magento.com/guides/v2.4/coding-standards/docblock-standard-general.html#documentation-space, the
@authortag is not permitted in Magento. This pull request removes this tag from (some of) theMagento_Catalogmodule. Given there are so many instances of this tag, I've opened a small pull request to get the process started. I expect that the linter will force me to fix several other coding standards violations on the way, so having a smaller pull request means that task is easier to manage. I plan to open more pull requests to tackle the other instances of this tag.See also magento/magento-coding-standard#382 and magento/magento-coding-standard#167
See also #36304, #36976, #36977, #36978, #36979, #36980, #36981
Manual testing scenarios
There are not code changes in this pull request. This pull request only removes forbidden comments.
Contribution checklist
Resolved issues:
@authortag fromMagento_Catalog(part 1) #37246: Remove forbidden@authortag fromMagento_Catalog(part 1)