Remove forbidden `@author` tag from `Magento_Downloadable` by fredden · Pull Request #37001 · magento/magento2

fredden · 2023-03-07T13:39:29Z

Description

According to https://devdocs.magento.com/guides/v2.4/coding-standards/docblock-standard-general.html#documentation-space, the @author tag is not permitted in Magento. This pull request removes this tag from some modules. Given there are so many instances of this tag, I've opened a small pull request to get the process started. I expect that the linter will force me to fix several other coding standards violations on the way, so having a smaller pull request means that task is easier to manage. I plan to open more pull requests to tackle the other instances of this tag.

See also magento/magento-coding-standard#382 and magento/magento-coding-standard#167

See also #36304, #36976, #36977, #36978, #36979, #36980, #36981, #36987, #36988, #36989,
#36990, #36991, #36993, #36999, #37000

Manual testing scenarios

There are not code changes in this pull request. This pull request only removes forbidden comments.

Contribution checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Remove forbidden @author tag from Magento_Downloadable #37251: Remove forbidden @author tag from Magento_Downloadable

m2-assistant · 2023-03-07T13:39:33Z

Hi @fredden. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

magento-automated-testing · 2023-03-07T14:26:00Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

…wnloadable

magento-automated-testing · 2023-03-14T21:02:07Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2023-03-14T22:03:42Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

leonhelmus

Looks good to me!

leonhelmus · 2023-03-20T10:32:52Z

@magento create issue

ihor-sviziev · 2023-03-22T13:26:35Z

Adding the same priority as #36976 (comment)

engcom-Lima · 2023-03-27T12:07:46Z

@magento run all tests

magento-automated-testing · 2023-03-27T12:07:53Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Lima · 2023-04-14T12:21:07Z

@magento run all tests

magento-automated-testing · 2023-04-14T12:21:14Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Lima · 2023-04-18T09:17:37Z

@magento run Functional Tests B2B

magento-automated-testing · 2023-04-18T09:17:46Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Lima · 2023-04-18T10:33:34Z

@magento run Functional Tests EE

engcom-Lima · 2023-04-18T10:42:12Z

@magento run all tests

magento-automated-testing · 2023-04-18T10:42:17Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Lima · 2023-04-18T14:13:08Z

✔️ QA Passed

Preconditions:

Install fresh Magento 2.4-develop and PHP 8.1

Manual testing scenario:
Verified @author tag got removed from Magento_Downloadable module.

After: ✔️

No addiitional manual test cases is required for the regression as this PR related to the removal of the @author tag from the Magento_Downloadable module.

Multiple builds are failing hence, moving this PR to Extended Testing

engcom-Lima · 2023-04-18T14:20:53Z

@magento run Integration Tests, Static Tests

magento-automated-testing · 2023-04-18T14:29:33Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Echo · 2024-06-27T04:07:03Z

@magento run all tests

engcom-Echo · 2024-06-27T11:50:39Z

Functional Tests EE,Functional Tests CE,Functional Tests B2b failure are known and flaky failure and not related to PR changes.
Functional Tests EE

Functional Tests CE

Functional Tests B2B

Integration Tests failure are not related to PR changes

Hence moving it to merge in progress

engcom-Hotel · 2025-04-29T09:09:41Z

@magento run all tests

engcom-Hotel · 2025-04-30T13:59:21Z

@magento run all tests

engcom-Hotel · 2025-05-02T07:36:57Z

@magento run Functional Tests B2B, Functional Tests EE, Integration Tests

engcom-Hotel · 2025-05-02T13:54:49Z

@magento run ntegration Tests

magento-automated-testing · 2025-05-02T13:54:57Z

Failed to run the builds. Please try to re-run them later.

engcom-Hotel · 2025-05-02T13:54:57Z

@magento run integration Tests

Remove forbidden @author tag

4a2938f

m2-github-services added Partner: Fisheye partners-contribution Pull Request is created by Magento Partner labels Mar 7, 2023

fredden mentioned this pull request Mar 7, 2023

Remove forbidden @author tag from Magento_Eav #37002

Open

6 tasks

fredden added 2 commits March 14, 2023 20:59

Merge remote-tracking branch 'upstream/2.4-develop' into no-author/do…

8935725

…wnloadable

Fix static test failures

4c3bb9d

leonhelmus approved these changes Mar 20, 2023

View reviewed changes

m2-community-project bot assigned leonhelmus Mar 20, 2023

m2-community-project bot added the Progress: ready for testing label Mar 20, 2023

This was referenced Mar 20, 2023

[Issue] Remove forbidden @author tag from Magento_Downloadable #37251

Closed

[Issue] Remove forbidden @author tag from Magento_Eav #37252

Open

ihor-sviziev added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 22, 2023

Merge branch '2.4-develop' into no-author/downloadable

23b2fda

Merge branch '2.4-develop' into no-author/downloadable

de8c877

engcom-Lima self-assigned this Apr 18, 2023

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Apr 18, 2023

Merge branch '2.4-develop' into no-author/downloadable

2534312

m2-community-project bot added Progress: extended testing and removed Progress: testing in progress labels Apr 18, 2023

Merge branch '2.4-develop' into no-author/downloadable

b993614

m2-community-project bot added Progress: accept and removed Progress: extended testing labels Jun 27, 2024

engcom-Echo self-assigned this Jun 27, 2024

m2-community-project bot added Progress: ready for testing and removed Progress: accept labels Jun 27, 2024

m2-community-project bot added Progress: accept and removed Progress: ready for testing labels Jul 9, 2024

Merge branch '2.4-develop' into no-author/downloadable

8f89862

glo24157 and others added 2 commits April 30, 2025 19:26

Update copyright information

3a10c4b

Merge branch '2.4-develop' into no-author/downloadable

ad665fd

magento-devops-reposync-svc merged commit a2ade32 into magento:2.4-develop May 10, 2025
12 checks passed

ct-prd-projects-boards-automation bot moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard May 10, 2025

fredden deleted the no-author/downloadable branch May 10, 2025 17:21

Conversation

fredden commented Mar 7, 2023 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Manual testing scenarios

Contribution checklist

Resolved issues:

Uh oh!

m2-assistant bot commented Mar 7, 2023

Uh oh!

magento-automated-testing bot commented Mar 7, 2023

Uh oh!

magento-automated-testing bot commented Mar 14, 2023

Uh oh!

magento-automated-testing bot commented Mar 14, 2023

Uh oh!

leonhelmus left a comment

Choose a reason for hiding this comment

Uh oh!

leonhelmus commented Mar 20, 2023

Uh oh!

ihor-sviziev commented Mar 22, 2023

Uh oh!

engcom-Lima commented Mar 27, 2023

Uh oh!

magento-automated-testing bot commented Mar 27, 2023

Uh oh!

engcom-Lima commented Apr 14, 2023

Uh oh!

magento-automated-testing bot commented Apr 14, 2023

Uh oh!

engcom-Lima commented Apr 18, 2023

Uh oh!

magento-automated-testing bot commented Apr 18, 2023

Uh oh!

engcom-Lima commented Apr 18, 2023

Uh oh!

engcom-Lima commented Apr 18, 2023

Uh oh!

magento-automated-testing bot commented Apr 18, 2023

Uh oh!

engcom-Lima commented Apr 18, 2023

Uh oh!

engcom-Lima commented Apr 18, 2023

Uh oh!

magento-automated-testing bot commented Apr 18, 2023

Uh oh!

engcom-Echo commented Jun 27, 2024

Uh oh!

engcom-Echo commented Jun 27, 2024

Uh oh!

engcom-Hotel commented Apr 29, 2025

Uh oh!

engcom-Hotel commented Apr 30, 2025

Uh oh!

engcom-Hotel commented May 2, 2025

Uh oh!

engcom-Hotel commented May 2, 2025

Uh oh!

magento-automated-testing bot commented May 2, 2025

Uh oh!

engcom-Hotel commented May 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

fredden commented Mar 7, 2023 •

edited by m2-assistant bot

Loading