Skip to content

Add MSRV check for manual_noop_waker#16850

Merged
samueltardieu merged 1 commit into
rust-lang:masterfrom
lapla-cogito:noopwaker_msrv
Apr 14, 2026
Merged

Add MSRV check for manual_noop_waker#16850
samueltardieu merged 1 commit into
rust-lang:masterfrom
lapla-cogito:noopwaker_msrv

Conversation

@lapla-cogito
Copy link
Copy Markdown
Contributor

@lapla-cogito lapla-cogito commented Apr 14, 2026

Fixes #16849

changelog: [manual_noop_waker]: Add MSRV check

Summary Notes

Managed by @rustbot—see help for details

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 14, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 14, 2026

r? @samueltardieu

rustbot has assigned @samueltardieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: 7 candidates
  • 7 candidates expanded to 7 candidates
  • Random selection from Jarcho, dswij, llogiq, samueltardieu

@samueltardieu samueltardieu added this pull request to the merge queue Apr 14, 2026
@samueltardieu
Copy link
Copy Markdown
Member

@rustbot label +beta-nominated
@rustbot note Beta-nomination

This should be backported to 0.96, to avoid the new lint, currently in beta, to exhibit this false positive.

@rustbot rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 14, 2026
Merged via the queue into rust-lang:master with commit ded0118 Apr 14, 2026
13 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 14, 2026
@flip1995 flip1995 added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels May 21, 2026
@flip1995
Copy link
Copy Markdown
Member

rust-lang/rust#156793

rust-bors Bot pushed a commit to rust-lang/rust that referenced this pull request May 21, 2026
[beta] Clippy backport

Backporting two fixes in Clippy

- rust-lang/rust-clippy#16850
- rust-lang/rust-clippy#16878

The first one fixes a lint that was added in 1.96.0 (current beta), so that this bug doesn't go to stable. The second one fixes a suggestion that can cause bugs in the code of our users.

Both commits are already on the r-l/r main branch.

r? Mark-Simulacrum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta-accepted Accepted for backporting to the compiler in the beta channel.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

manual_noop_waker makes a suggestion that's too new for my MSRV

4 participants