New lint: borrow_mutable_copy#13984
Closed
samueltardieu wants to merge 1 commit into
Closed
Conversation
Collaborator
rustbot
added
the
S-waiting-on-review
samueltardieu
force-pushed
the
push-kpvspntvlrtr
branch
2 times, most recently
from
a881f75 to
1ac5de7
Compare
samueltardieu
force-pushed
the
push-kpvspntvlrtr
branch
from
1ac5de7 to
f521ce9
Compare
Member
Author
|
Rebased |
samueltardieu
force-pushed
the
push-kpvspntvlrtr
branch
from
f521ce9 to
9e3a25e
Compare
Member
Author
|
Rebased |
Member
Author
|
r? @Clippy |
samueltardieu
force-pushed
the
push-kpvspntvlrtr
branch
from
9e3a25e to
5a08c09
Compare
Member
Author
|
Rebased |
samueltardieu
force-pushed
the
push-kpvspntvlrtr
branch
from
5a08c09 to
0de459a
Compare
Member
Author
|
Rebased |
flip1995
reviewed
Feb 10, 2025
samueltardieu
force-pushed
the
push-kpvspntvlrtr
branch
from
0de459a to
7b849af
Compare
Member
Author
|
@flip1995 Anything else needs to be done? |
Member
|
I guess the FCP on Zulip. Feel free to start that :) |
Member
Author
samueltardieu
force-pushed
the
push-kpvspntvlrtr
branch
2 times, most recently
from
410fe93 to
b0e27cc
Compare
Alexendoo
reviewed
Mar 22, 2025
samueltardieu
force-pushed
the
push-kpvspntvlrtr
branch
4 times, most recently
from
eac9c71 to
5309578
Compare
samueltardieu
force-pushed
the
push-kpvspntvlrtr
branch
from
1528363 to
45d489d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
samueltardieu
force-pushed
the
push-kpvspntvlrtr
branch
from
45d489d to
ebe14c6
Compare
This comment has been minimized.
This comment has been minimized.
samueltardieu
force-pushed
the
push-kpvspntvlrtr
branch
from
ebe14c6 to
84ffdfa
Compare
This comment has been minimized.
This comment has been minimized.
samueltardieu
force-pushed
the
push-kpvspntvlrtr
branch
from
84ffdfa to
b35f6f8
Compare
This comment has been minimized.
This comment has been minimized.
samueltardieu
force-pushed
the
push-kpvspntvlrtr
branch
from
b35f6f8 to
874bce7
Compare
This comment has been minimized.
This comment has been minimized.
samueltardieu
force-pushed
the
push-kpvspntvlrtr
branch
from
874bce7 to
847d3ff
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
samueltardieu
force-pushed
the
push-kpvspntvlrtr
branch
from
847d3ff to
2e94c82
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
samueltardieu
force-pushed
the
push-kpvspntvlrtr
branch
from
2e94c82 to
49e0f02
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
samueltardieu
force-pushed
the
push-kpvspntvlrtr
branch
from
49e0f02 to
ff0f3fd
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
samueltardieu
force-pushed
the
push-kpvspntvlrtr
branch
from
ff0f3fd to
480ac81
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Collaborator
|
☔ The latest upstream changes (possibly #16025) made this pull request unmergeable. Please resolve the merge conflicts. |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View all comments
This detects when the result of a block, with a
Copytype, is borrowed mutably. The user might not be aware that using a block will borrow a copy instead of the value expression itself.changelog: [
borrow_mutable_copy]: new lintClose #13967