Add excessive_file_length lint#16760
Open
nickelser wants to merge 3 commits into
Open
Conversation
rustbot
added
needs-fcp
Collaborator
|
r? @llogiq rustbot has assigned @llogiq. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
Lintcheck changes for 1cb110a
This comment will be updated if you push new changes |
This comment has been minimized.
This comment has been minimized.
nickelser
force-pushed
the
excessive-file-length
branch
from
83597d3 to
ac6e1ff
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
nickelser
force-pushed
the
excessive-file-length
branch
from
ac6e1ff to
903926b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
nickelser
force-pushed
the
excessive-file-length
branch
from
903926b to
4df0890
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Counts code lines only (via rustc_lexer), skipping comments and blank lines. Configurable via excessive-file-length-threshold in clippy.toml (default 500). changelog: new lint: [`excessive_file_length`]
nickelser
force-pushed
the
excessive-file-length
branch
from
4df0890 to
1cb110a
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Author
|
@llogiq hey, should i reassign to someone? i've been trying to keep it updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
restrictionlint that flags source files exceeding a configurable line count. Code lines only (no blanks/comments).Supersedes #15922; tried to address feedback there.
changelog: new lint: [excessive_file_length]