Extend byte_char_slices to cover arrays

[profetia]

Closes #16759

changelog: [byte_char_slices] enhance to cover arrays

[rustbot]

r? @samueltardieu

rustbot has assigned @samueltardieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: 7 candidates
• 7 candidates expanded to 7 candidates
• Random selection from Jarcho, dswij, llogiq, samueltardieu

[github-actions]

Lintcheck changes for d0c0f3a

Lint	Added	Removed	Changed
clippy::byte_char_slices	4	0	0

This comment will be updated if you push new changes

[samueltardieu]

I wonder whether it would be interesting to see how this array is then used. If all uses are adjusted and auto-dereferenced, then suggesting b"…" (without *) would make sense.

[profetia]

Agree.

[profetia]

Implemented. The lint is now moved to late pass. I also avoid arrays with comments or cfg, looking into the lint check results.

[samueltardieu]

Could you also add some more tests? Like:

    let with_escape: u8 = [b'\'', b'"', b'\x00', b'\n', b'\\'].iter().copied().sum();
    //~^ byte_char_slices

    takes_array_ref(&[b'a', b'b']);
    //~^ byte_char_slices

    takes_array_ref_ref(&&[b'a', b'b']);
    //~^ byte_char_slices
}

fn takes_array_ref(_: &[u8; 2]) {}

fn takes_array_ref_ref(_: &&[u8; 2]) {}

View changes since this review

[samueltardieu]

Last nit: could you fix the PR title, the commit message and the changelog? This is not really a false negative as the lint name talks about slices, this is more of an enhancement, so that byte_char_slices now handle arrays as well.

View changes since this review

[profetia]

Done. Thank you!

[samueltardieu]

@profetia Tell me when you've rebased it and I'll merge it.

[samueltardieu]

Also, can you invert the order of the two commits? This would make sure that tests pass after every commit, whereas in the current situation after the first commit tests won't pass.

[rustbot]

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[samueltardieu]

I was able to do the rebase and commit inversion. I'll merge.

View changes since this review

[profetia]

I have been quite busy lately. Big thanks for help working on this :)