Handle different root contexts in SpanlessEq

[Jarcho]

View all comments

This is needed for SpanlessEq to work correctly inside a macro expansion. The context selected for some of the lints may be wrong, but most of them don't handle macros correctly in the first place so this won't really be a regression. Without this change SpanlessEq would essentially assume the root context which isn't always correct.

changelog: none

[rustbot]

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[github-actions]

Lintcheck changes for 14e481d

Lint	Added	Removed	Changed
clippy::match_same_arms	0	1	0

This comment will be updated if you push new changes

[Jarcho]

The lintcheck change looks like the arms could technically be merged. It's no longer being matched because a variable passed in to quote_spanned has a different name. In general this would be a FP because macro expansion can change based on that.

[blyxyas]

I currently can't handle any reviews, sorry for the delay. I'll re-rotate and another team member will take this one.
r? clippy

[rustbot]

Error: assign handler unexpectedly failed in this comment: error decoding response body

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

[blyxyas]

r? blyxyas

Seems that the handler is failing for any assignation. I'll post a message on Zulip

[rustbot]

Error: assign handler unexpectedly failed in this comment: error decoding response body

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

[Urgau]

r? clippy

[Jarcho]

r? clippy

[rustbot]

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.