fix(mut_mutex_lock): don't lint on indexing and field accesses#16435
Open
ada4a wants to merge 2 commits intorust-lang:masterfrom
Open
fix(mut_mutex_lock): don't lint on indexing and field accesses#16435ada4a wants to merge 2 commits intorust-lang:masterfrom
ada4a wants to merge 2 commits intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
Contributor
|
Like in the other PR you are still going to need to find the projection base (i.e. walk deref calls) and check that all derefs can be switched to their mutable form. A "known problems" section needs to be added to the lint to explain how the lint doesn't take lifetimes into account as well. |
Collaborator
|
☔ The latest upstream changes (possibly #15793) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A v2 of #16261, due to #16261 (comment)
Fixes #16253
changelog: [
mut_mutex_lock]: don't lint on indexing and field accessesr? @Jarcho