Snippet rework

[Jarcho]

View all comments

This is a further rework of our snippet accessing/creating code.

The general design goals with this:

• Avoid allocating when not strictly necessary.
• Make it easy to avoid linting if an invalid span is used.
• Make it easier to debug when an invalid span is used.
• Make it easy to minimize the number of lookups in the source map.
• Make it easy to avoid creating intermediary compressed spans.
• Make it as easy as possible to compose span adjustments/checks while maintaining the previous goals.

changelog: None

[rustbot]

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[Jarcho]

The first two commits are mainly renames. The third commit has all the actual changes.

[Jarcho]

Looking at MISSING_DOCS_IN_PRIVATE_ITEMS, that lint needs to be restructured a bit. Macros currently mess up it's implementation quite a bit.

Why is this not part of rustc in the first place?

[github-actions]

Lintcheck changes for 17db42c

Lint	Added	Removed	Changed
clippy::manual_ok_or	0	0	16
clippy::match_same_arms	0	1	0
clippy::multiple_bound_locations	0	2	0

This comment will be updated if you push new changes

[Jarcho]

Blocked on #15793. Needed so we can assert we never access external sources.

[rustbot]

☔ The latest upstream changes (possibly 807dea0) made this pull request unmergeable. Please resolve the merge conflicts.

[rustbot]

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.