Skip to content

Make collapsible_if to cover nested ifs with identical else#16563

Open
profetia wants to merge 2 commits intorust-lang:masterfrom
profetia:issue16561
Open

Make collapsible_if to cover nested ifs with identical else#16563
profetia wants to merge 2 commits intorust-lang:masterfrom
profetia:issue16561

Conversation

@profetia
Copy link
Copy Markdown
Member

@profetia profetia commented Feb 13, 2026 •
edited by rustbot
Loading

Closes #16561

changelog: [collapsible_if] enhance to cover nested ifs with identical else

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 13, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Feb 13, 2026

r? @samueltardieu

rustbot has assigned @samueltardieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: 7 candidates
  • 7 candidates expanded to 7 candidates
  • Random selection from Jarcho, dswij, llogiq, samueltardieu

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 13, 2026 •
edited
Loading

No changes for ed63317

@samueltardieu
Copy link
Copy Markdown
Member

samueltardieu commented Feb 15, 2026 •
edited
Loading

As shown in the lintcheck change, you should probably not propose to merge the else if they contain comments unless they're also identical.

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Feb 15, 2026
@profetia
Copy link
Copy Markdown
Member Author

profetia commented Feb 23, 2026

Updated. Thank you!

@profetia
Copy link
Copy Markdown
Member Author

profetia commented Feb 23, 2026

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Feb 23, 2026
@rustbot

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@profetia
Copy link
Copy Markdown
Member Author

profetia commented Mar 31, 2026

r? clippy

@rustbot rustbot assigned Jarcho and unassigned samueltardieu Mar 31, 2026
@profetia
Copy link
Copy Markdown
Member Author

profetia commented Apr 12, 2026

r? clippy

@rustbot rustbot assigned llogiq and unassigned Jarcho Apr 12, 2026
@rustbot

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 2, 2026

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@llogiq llogiq

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Extend collapsible_if to cover nested ifs with identical else

5 participants

@profetia @rustbot @samueltardieu @llogiq @Jarcho