Skip to content

fix: omit secret parameters from action outputs - #255

Merged
phantom-jacob merged 2 commits into
mainfrom
sodle/papp-37946-password-output-exemption
Aug 3, 2026
Merged

phantom-jacob merged 2 commits into
mainfrom
sodle/papp-37946-password-output-exemption

Conversation

@sodle-splunk

@sodle-splunk sodle-splunk commented Aug 1, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Exclude password- and encrypted-typed action parameters from the static test that requires action-result parameter metadata.
  • Remove existing secret parameter output paths when the autofix runs.
  • Add focused regression coverage for both missing and existing password and encrypted outputs.

Why this belongs here

The shared action_param_prefixes autofix currently recreates secret output metadata removed by connector remediations. Fixing individual connector manifests cannot pass the required pre-commit gate because the central hook reverses the change. This update establishes the correct rule once for every connector and blocks the VULN-95113 follow-up PRs until released.

Verification

  • uv run --python 3.9 --with-requirements ../pre-commit/dev-requirements.txt pytest tests/test_static_tests.py -q from local_hooks/ (10 passed)
  • pre-commit run --all-files --show-diff-on-failure

References: PAPP-37946, PSAAS-32390, and VULN-95113.

Authored and prepared by Codex.

Prevent the static-test autofix from publishing password-typed action parameters and remove any existing password parameter output paths.

References PAPP-37946, PSAAS-32390, and VULN-95113.

Authored by Codex.
Comment thread local_hooks/app_tests/json_tests.py Resolved
Exclude both password and encrypted action parameters from generated action-result paths, with focused coverage for adding and removing outputs.

Authored-by: Codex
@sodle-splunk sodle-splunk changed the title fix: omit password parameters from action outputs fix: omit secret parameters from action outputs Aug 3, 2026
@phantom-jacob
phantom-jacob merged commit 327cded into main Aug 3, 2026
4 checks passed
@phantom-jacob
phantom-jacob deleted the sodle/papp-37946-password-output-exemption branch August 3, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants