Skip to content

fix: redact action-scoped AWS credentials - #25

Open
sodle-splunk wants to merge 15 commits into
mainfrom
sodle/espm-5228-awssecurityhub-credential-redaction
Open

sodle-splunk wants to merge 15 commits into
mainfrom
sodle/espm-5228-awssecurityhub-credential-redaction

Conversation

@sodle-splunk

@sodle-splunk sodle-splunk commented Aug 1, 2026 •

Copy link
Copy Markdown
Contributor

Written by Codex.

Summary

  • Mark temporary AWS credentials as password-typed action input.
  • Exclude action-scoped credentials before parameters are retained in ActionResult.
  • Remove credential parameter paths from action output metadata.
  • Preserve PR fix!: harden Security Hub ingestion boundaries #24's polling-loss protections and pagination bounds.
  • Refresh shared quality hooks and their generated maintenance artifacts.

Tracking

Rebase reconciliation

PR #25 was rebased onto PR #24 at dee5a7b115775e83d73b03958aba6bfc8c2a7417. Combined head fa97b6cd66db7c0cced7075abe58047aa613251d preserves PR #24's stable first-run boundary, checkpoint migration, SQS occurrence and deferred-message tracking, malformed-message fail-closed behavior, durable-prefix checkpointing, pagination bounds, and finite scheduled-poll handling while adding credential redaction.

Exact source reconciliation confirms that the regression caused by the old PR #25 base is removed. VULN-94532 therefore returns to PR #24's connector-complete state; its previously documented invocation-mode classification remains a separate platform follow-up.

Quality gate

  • Full local pre-commit passes except for environment-only failures: Semgrep cannot initialize the local certificate store, and dependency packaging cannot run without Docker.
  • Source compilation passes locally.
  • All other local hooks pass, including merge-conflict checks, formatting, linting, app linting, secret detection, documentation, copyright, release-note, and static-test checks.
  • Hosted checks will rerun at the rebased head.

Release impact

Asset configuration and credential use are unchanged. The action history no longer retains temporary credential material. PR #24's intentionally breaking polling and result-bound changes remain part of the combined release.

Merge strategy: merge commit only; do not squash.

Persist a fixed first-run boundary, migrate legacy checkpoints through a conservative UTC lookback, and keep scheduled checkpointing independent of poll-now classification.

Authored by Codex.
Request only the remaining local allowance and reject oversized provider pages before accumulating findings.

Authored by Codex.
Persist successful finding IDs per SQS message so capped polls resume at the unprocessed tail and delete only after full durable ingestion.

Authored by Codex.
Authored by Codex.
@github-actions

github-actions Bot commented Aug 1, 2026 •

Copy link
Copy Markdown

Merging this PR will release 3.0.0 with the following release notes:

3.0.0 (2026-08-12)

Connector release changes

  • Stabilize scheduled polling windows and migrate invalid legacy checkpoints to a safe UTC lookback.
  • Preserve older valid checkpoints during migration so unprocessed findings remain in the polling window.
  • Reject provider pages that exceed the requested local finding allowance before accumulation.
  • Limit omitted-result pagination to 1,000 findings and exact-ID validation to 100 retained findings.
  • Reuse the bounded exact-ID result for related-finding output instead of issuing a second unbounded request.
  • Persist per-message SQS progress so capped polls resume at the unprocessed finding.
  • Track SQS ingestion by exact message occurrence and delete only fully ingested messages.
  • Rotate capped SQS retries past persistent failures and report deferred or invalid messages.
  • Prioritize messages deferred by an earlier poll so persistent failures cannot starve later messages.
  • Continue direct polling after individual ingestion failures without checkpointing past the earliest failure.
  • Prevent action-scoped AWS credentials from being retained in action results.

Limit omitted-result pagination to 1,000 findings and exact-ID validation to one page.

BREAKING CHANGE: Omitted or oversized finding limits now return at most 1,000 findings per action.

Authored by Codex.
Describe the exact retained-item guarantees without implying a single provider request.

Authored by Codex.
Scope SQS ingestion progress to a message body and occurrence index so repeated finding identifiers cannot credit unrelated records.

Authored-by: Codex
Keep legacy checkpoints conservative, rotate capped message retries, continue later direct findings, and report deferred or invalid queue records.

Authored-by: Codex
Persist deferred message order so a repeatedly failing record cannot monopolize the poll cap and starve later received messages.

Authored-by: Codex
Avoid a second unbounded related-findings request after exact-ID validation by reusing the already validated bounded response.

Authored-by: Codex
@sodle-splunk
sodle-splunk marked this pull request as ready for review August 2, 2026 08:39
@sodle-splunk
sodle-splunk marked this pull request as draft August 3, 2026 23:39
@sodle-splunk
sodle-splunk marked this pull request as ready for review August 7, 2026 18:26
Refresh pre-commit hooks and apply their generated maintenance updates before the connector behavior change.

Authored by Codex.
Mark temporary credentials as password input, omit them from persisted ActionResult parameters, and remove their output metadata.

References PAPP-37946, PSAAS-32390, and VULN-95113.

Authored by Codex.
Authored-by: Codex <codex@openai.com>
Use dev-cicd-tools v2.2.9 so generated metadata follows the corrected secret-output handling.

Authored-by: Codex <codex@openai.com>
Regenerate connector metadata with the corrected validation hook so password parameters are not advertised as action outputs.

Authored-by: Codex <codex@openai.com>
@sodle-splunk
sodle-splunk force-pushed the sodle/espm-5228-awssecurityhub-credential-redaction branch from d3f9813 to fa97b6c Compare August 11, 2026 21:05
@phantom-jacob

Copy link
Copy Markdown
Contributor

Codex review blocker: the current history contains literal \n text in the commit bodies for a23052c8, fa97b6cd. Those are two characters, not paragraph breaks. Please rewrite the affected commit messages with real newlines so release tooling and trailers see valid multiline messages. Preserve the distinct commits rather than squashing them.

Commented by Codex.

@sodle-splunk
sodle-splunk force-pushed the sodle/espm-5228-awssecurityhub-credential-redaction branch from fa97b6c to da8d5ab Compare August 12, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants