Repository navigation
fix: redact action-scoped AWS credentials - #25
Open
sodle-splunk wants to merge 15 commits into
Open
sodle-splunk wants to merge 15 commits into
sodle-splunk wants to merge 15 commits into
Conversation
Persist a fixed first-run boundary, migrate legacy checkpoints through a conservative UTC lookback, and keep scheduled checkpointing independent of poll-now classification. Authored by Codex.
Request only the remaining local allowance and reject oversized provider pages before accumulating findings. Authored by Codex.
Persist successful finding IDs per SQS message so capped polls resume at the unprocessed tail and delete only after full durable ingestion. Authored by Codex.
Authored by Codex.
|
Merging this PR will release 3.0.0 (2026-08-12)Connector release changes
|
Limit omitted-result pagination to 1,000 findings and exact-ID validation to one page. BREAKING CHANGE: Omitted or oversized finding limits now return at most 1,000 findings per action. Authored by Codex.
Describe the exact retained-item guarantees without implying a single provider request. Authored by Codex.
Scope SQS ingestion progress to a message body and occurrence index so repeated finding identifiers cannot credit unrelated records. Authored-by: Codex
Keep legacy checkpoints conservative, rotate capped message retries, continue later direct findings, and report deferred or invalid queue records. Authored-by: Codex
Persist deferred message order so a repeatedly failing record cannot monopolize the poll cap and starve later received messages. Authored-by: Codex
Avoid a second unbounded related-findings request after exact-ID validation by reusing the already validated bounded response. Authored-by: Codex
sodle-splunk
marked this pull request as ready for review
August 2, 2026 08:39
sodle-splunk
marked this pull request as draft
August 3, 2026 23:39
sodle-splunk
marked this pull request as ready for review
August 7, 2026 18:26
Refresh pre-commit hooks and apply their generated maintenance updates before the connector behavior change. Authored by Codex.
Mark temporary credentials as password input, omit them from persisted ActionResult parameters, and remove their output metadata. References PAPP-37946, PSAAS-32390, and VULN-95113. Authored by Codex.
Authored-by: Codex <codex@openai.com>
Use dev-cicd-tools v2.2.9 so generated metadata follows the corrected secret-output handling. Authored-by: Codex <codex@openai.com>
Regenerate connector metadata with the corrected validation hook so password parameters are not advertised as action outputs. Authored-by: Codex <codex@openai.com>
sodle-splunk
force-pushed
the
sodle/espm-5228-awssecurityhub-credential-redaction
branch
from
August 11, 2026 21:05
d3f9813 to
fa97b6c
Compare
Contributor
|
Codex review blocker: the current history contains literal Commented by Codex. |
sodle-splunk
force-pushed
the
sodle/espm-5228-awssecurityhub-credential-redaction
branch
from
August 12, 2026 14:09
fa97b6c to
da8d5ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written by Codex.
Summary
Tracking
Rebase reconciliation
PR #25 was rebased onto PR #24 at
dee5a7b115775e83d73b03958aba6bfc8c2a7417. Combined headfa97b6cd66db7c0cced7075abe58047aa613251dpreserves PR #24's stable first-run boundary, checkpoint migration, SQS occurrence and deferred-message tracking, malformed-message fail-closed behavior, durable-prefix checkpointing, pagination bounds, and finite scheduled-poll handling while adding credential redaction.Exact source reconciliation confirms that the regression caused by the old PR #25 base is removed. VULN-94532 therefore returns to PR #24's connector-complete state; its previously documented invocation-mode classification remains a separate platform follow-up.
Quality gate
Release impact
Asset configuration and credential use are unchanged. The action history no longer retains temporary credential material. PR #24's intentionally breaking polling and result-bound changes remain part of the combined release.
Merge strategy: merge commit only; do not squash.