Skip to content

fix: redact action-scoped AWS credentials - #34

Merged
sodle-splunk merged 6 commits into
mainfrom
sodle/espm-5228-awsathena-credential-redaction
Sep 14, 2026
Merged

sodle-splunk merged 6 commits into
mainfrom
sodle/espm-5228-awsathena-credential-redaction

Conversation

@sodle-splunk

@sodle-splunk sodle-splunk commented Aug 1, 2026 •

Copy link
Copy Markdown
Contributor

Written by Codex.

Summary

  • Mark temporary AWS credentials as password-typed action input.
  • Exclude action-scoped credentials before parameters are retained in ActionResult.
  • Remove credential parameter paths from action output metadata.
  • Refresh shared quality hooks and their generated maintenance artifacts.

Tracking

Quality gate

  • Full pre-commit suite passes locally and the hosted pre-commit check passes at the corrected head.

  • Source compilation passes locally.

  • Hosted compile rerun passed on 2026-08-07; no connector-code compile failure remains.

  • Security scans are non-blocking under the connector quality policy; integration failures are ignored unless they implicate the changed code.

Release impact

Asset configuration and credential use are unchanged. The action history no longer retains temporary credential material.

Merge strategy: merge commit only; do not squash.

Refresh pre-commit hooks and apply their generated maintenance updates before the connector behavior change.

Authored by Codex.
Mark temporary credentials as password input, omit them from persisted ActionResult parameters, and remove their output metadata.

References PAPP-37946, PSAAS-32390, and VULN-95113.

Authored by Codex.
@github-actions

github-actions Bot commented Aug 1, 2026 •

Copy link
Copy Markdown

Merging this PR will release 2.3.3 with the following release notes:

2.3.3 (2026-08-12)

Connector release changes

  • Prevent action-scoped AWS credentials from being retained in action results.

@sodle-splunk
sodle-splunk marked this pull request as ready for review August 2, 2026 08:39
Use dev-cicd-tools v2.2.9 so generated metadata follows the corrected secret-output handling.

Authored-by: Codex <codex@openai.com>
Regenerate connector metadata with the corrected validation hook so password parameters are not advertised as action outputs.

Authored-by: Codex <codex@openai.com>
Run the existing changes against the current shared workflow after the prior workflow identifier was retired.

Authored-by: Codex <codex@openai.com>
@sodle-splunk
sodle-splunk marked this pull request as draft August 3, 2026 23:39
@sodle-splunk
sodle-splunk marked this pull request as ready for review August 7, 2026 18:26
@phantom-jacob

Copy link
Copy Markdown
Contributor

Codex review blocker: the current history contains literal \n text in the commit bodies for c5bd3651, 7677f92e, 24bfcc51. Those are two characters, not paragraph breaks. Please rewrite the affected commit messages with real newlines so release tooling and trailers see valid multiline messages. Preserve the distinct commits rather than squashing them.

Commented by Codex.

@sodle-splunk
sodle-splunk force-pushed the sodle/espm-5228-awsathena-credential-redaction branch from 24bfcc5 to 2e080e7 Compare August 12, 2026 14:09

@ChrisGeohring ChrisGeohring left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the current head for P0/P1 code issues. No P0/P1 code blocker found. This approval covers the connector code review; any shared sanity, integration, or test-inventory gates remain separate CI follow-up.

@sodle-splunk
sodle-splunk merged commit c6d34cc into main Sep 14, 2026
55 of 80 checks passed
@sodle-splunk
sodle-splunk deleted the sodle/espm-5228-awsathena-credential-redaction branch September 14, 2026 21:29
@splunk-soar-semantic-release

Copy link
Copy Markdown

🎉 This PR is included in version 2.3.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants