Repository navigation
fix: redact action-scoped AWS credentials - #34
Merged
sodle-splunk merged 5 commits intoSep 14, 2026
Merged
Conversation
sodle-splunk
marked this pull request as ready for review
August 2, 2026 08:39
sodle-splunk
marked this pull request as draft
August 3, 2026 23:39
sodle-splunk
marked this pull request as ready for review
August 7, 2026 18:27
Contributor
|
Codex review blocker: the current history contains literal Commented by Codex. |
sodle-splunk
force-pushed
the
sodle/espm-5228-awswafv2-credential-redaction
branch
from
August 12, 2026 14:09
7de89e3 to
3beaeb4
Compare
Refresh pre-commit hooks and apply their generated maintenance updates before the connector behavior change. Authored by Codex.
Mark temporary credentials as password input, omit them from persisted ActionResult parameters, and remove their output metadata. References PAPP-37946, PSAAS-32390, and VULN-95113. Authored by Codex.
Authored-by: Codex <codex@openai.com>
Use dev-cicd-tools v2.2.9 so generated metadata follows the corrected secret-output handling. Authored-by: Codex <codex@openai.com>
Regenerate connector metadata with the corrected validation hook so password parameters are not advertised as action outputs. Authored-by: Codex <codex@openai.com>
sodle-splunk
force-pushed
the
sodle/espm-5228-awswafv2-credential-redaction
branch
from
September 14, 2026 16:01
3beaeb4 to
47539cf
Compare
ChrisGeohring
approved these changes
Sep 14, 2026
ChrisGeohring
left a comment
ChrisGeohring
left a comment
There was a problem hiding this comment.
Reviewed the current head for P0/P1 code issues. No P0/P1 code blocker found. This approval covers the connector code review; any shared sanity, integration, or test-inventory gates remain separate CI follow-up.
sodle-splunk
deleted the
sodle/espm-5228-awswafv2-credential-redaction
branch
September 14, 2026 21:31
|
🎉 This PR is included in version 2.1.14 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written by Codex.
Summary
Tracking
Quality gate
Full pre-commit suite passes locally and the hosted pre-commit check passes at the corrected head.
Source compilation passes locally.
Hosted compile rerun passed on 2026-08-07; no connector-code compile failure remains.
Security scans are non-blocking under the connector quality policy; integration failures are ignored unless they implicate the changed code.
Release impact
Asset configuration and credential use are unchanged. The action history no longer retains temporary credential material.
Merge strategy: merge commit only; do not squash.