Replace some custom copy functions with #[derive(Clone)].#11487
Merged
vorporeal merged 1 commit intoJun 1, 2026
Conversation
This was referenced May 21, 2026
This was referenced May 21, 2026
1 task
Contributor
Author
1 task
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR replaces a handwritten Clone implementation for ObjectsToUpdate with #[derive(Clone)] and adds Clone to UpdatedObjectInput, preserving the existing deep-clone behavior through the fields' Clone implementations.
Concerns
- No blocking correctness, security, or spec-alignment concerns found. No approved spec context was provided for this PR.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
vorporeal
force-pushed
the
david/replace-custom-copy-functions-with-clone-derive
branch
from
d2ae74c to
dafdf0c
Compare
vorporeal
force-pushed
the
david/extract-cloud-object-persistence
branch
from
01cd413 to
2ac0201
Compare
vorporeal
force-pushed
the
david/replace-custom-copy-functions-with-clone-derive
branch
2 times, most recently
from
dcc44e5 to
0a169f3
Compare
vorporeal
force-pushed
the
david/extract-cloud-object-persistence
branch
2 times, most recently
from
cdc014b to
28337ed
Compare
vorporeal
force-pushed
the
david/replace-custom-copy-functions-with-clone-derive
branch
2 times, most recently
from
0c5f1f7 to
ebdbc67
Compare
vorporeal
force-pushed
the
david/extract-cloud-object-persistence
branch
from
28337ed to
c0068a0
Compare
vorporeal
changed the base branch from
david/extract-cloud-object-persistence
to
graphite-base/11487
vorporeal
force-pushed
the
david/replace-custom-copy-functions-with-clone-derive
branch
from
ebdbc67 to
a0fa49f
Compare
vorporeal
changed the base branch from
graphite-base/11487
to
david/extract-cloud-object-persistence
vorporeal
changed the base branch from
david/extract-cloud-object-persistence
to
graphite-base/11487
vorporeal
force-pushed
the
david/replace-custom-copy-functions-with-clone-derive
branch
from
a0fa49f to
7ba9e46
Compare
vorporeal
changed the base branch from
graphite-base/11487
to
david/extract-cloud-object-persistence
vorporeal
force-pushed
the
david/replace-custom-copy-functions-with-clone-derive
branch
from
7ba9e46 to
632b8fd
Compare
bnavetta
approved these changes
Jun 1, 2026
vorporeal
deleted the
david/replace-custom-copy-functions-with-clone-derive
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses #11113 (comment).