Create cloud_objects crate.#11165
Merged
Merged
Conversation
This was referenced May 18, 2026
Contributor
Author
This was referenced May 18, 2026
5e352da to
f5fc243
Compare
d5b94a3 to
b434157
Compare
f5fc243 to
df91010
Compare
b434157 to
bac2d6a
Compare
1 task
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
Contributor
There was a problem hiding this comment.
Overview
This PR introduces a new cloud_objects crate and moves shared cloud object, Drive sharing, ID, and user UID types out of warp_server_client, while keeping compatibility re-exports for existing call sites.
Concerns
- No blocking correctness, security, or spec-alignment concerns found in the annotated diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
bac2d6a to
9239c96
Compare
df91010 to
5cfd599
Compare
9239c96 to
ec7be2a
Compare
3fd9cf9 to
9ba6eed
Compare
ec7be2a to
65ec5ea
Compare
9ba6eed to
ba1e0b4
Compare
631c76e to
d14fff2
Compare
ba1e0b4 to
a9aa277
Compare
a9aa277 to
b53fe9b
Compare
d14fff2 to
46f2759
Compare
b53fe9b to
c61cb4b
Compare
c61cb4b to
9bbf071
Compare
Co-Authored-By: Oz <oz-agent@warp.dev>
9bbf071 to
17c9a2e
Compare
bnavetta
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Creates a dedicated
cloud_objectscrate for the shared cloud object substrate that should not live inwarp_server_clientor the app crate.The new crate owns the low-level cloud object, Drive sharing, ID, and user UID types.
warp_server_clientnow depends on that crate and re-exports the moved modules so existing call sites can migrate incrementally while keeping this PR mostly mechanical.Linked Issue
None.
Testing
cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p cloud_objects -p warp_server_client --testscargo check --manifest-path /Users/david/src/warp/Cargo.toml -p warp --testsNo manual app testing; this is a crate-boundary refactor with no intended product behavior changes.
Agent Mode
CHANGELOG-NONE
Co-Authored-By: Oz oz-agent@warp.dev