Extract CloudObject client and models to separate crates.

[vorporeal]

Description

Extracts the concrete cloud object model layer and object client interface into dedicated crates so future cloud sync work can depend on them without depending on the full app crate.

This PR adds cloud_object_models for concrete server/model types and cloud_object_client for ObjectClient, object update messages, initial load responses, permissions/action result types, and related client-facing surfaces. The app and warp_server_client retain compatibility shims/re-exports while call sites are updated to use the extracted crates where appropriate.

The PR also moves model-only tests into cloud_object_models and restores docs/comments that were accidentally dropped during the migration.

Linked Issue

None.

Testing

• cargo fmt --manifest-path /Users/david/src/warp/Cargo.toml --all
• cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p cloud_object_models -p cloud_object_client
• cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p cloud_object_models -p warp --tests
• cargo nextest run --manifest-path /Users/david/src/warp/Cargo.toml -p cloud_object_models
• HOME=$(mktemp -d) cargo nextest run --manifest-path /Users/david/src/warp/Cargo.toml -p warp

No manual app testing; this is a crate-boundary refactor with no intended product behavior changes.

Agent Mode

• Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-NONE

Co-Authored-By: Oz oz-agent@warp.dev

[vorporeal]

• Extract cloud object persistence logic to other crates. #11179 : 2 dependent PRs (#11378 , #11487 )
• Extract CloudObject client and models to separate crates. #11166 👈 (View in Graphite)
• Create cloud_objects crate. #11165
• Move cloud object models to separate crate. #11164
• Move GenericStringModel to warp_server_client. #11117
• Move GenericCloudObject to warp_server_client. #11115
• Move GenericServerObject to warp_server_client. #11114
• Move some types to the warp_server_client crate. #11113
• Delete unused new_from_server_update function. #11112
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[oz-for-oss]

@vorporeal

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR extracts the CloudObject client interface and concrete cloud object models into new cloud_object_client and cloud_object_models crates, with app and warp_server_client compatibility re-exports.

Concerns

• cloud_object_client generates/uses MockObjectClient under cfg(test), but mockall is only an optional dependency enabled by the test-util feature, so the crate's own test build without that feature will fail before running tests.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

⚠️ [IMPORTANT] cfg(test) is true when this crate is compiled for its own tests, but mockall is optional and only enabled by test-util; cargo test -p cloud_object_client will fail to resolve this import unless mockall is also a dev-dependency or these gates only use the feature.

[bnavetta]

Putting the UI strings in a separate crate feels a bit off, but guess it's not super avoidable with Rust's orphan rules

[vorporeal]

yeah, and we could improve this with an extension trait, but i'm not really sure it's worth it

[bnavetta]

This probably belongs back in the app crate - doesn't seem to be used by any of the models?

[vorporeal]

fair. i've got a PR stacked on this one where i'm moving a bunch of the MCP stuff to the mcp crate (and some of the code being moved depends on this); i'll update that PR to move this into mcp instead of here.