Improve button styling in critical fix page.#2741
Merged
demiankatz merged 2 commits intoMar 13, 2023
Merged
Conversation
5 tasks
Member
Author
|
@crhallberg, I just turned off text decoration on buttons by default and that seems to allow this to look correct without adding the extra btn-link class. I looked at it in all three themes and it looks fine everywhere (though for some reason there's no mouseover reaction in bootprint3, even though bootstrap3/sandal cause a negative highlighting effect... but I don't think it's a big deal). Does this look reasonable to you, or do you think there might be unwanted side effects somewhere? |
crhallberg
approved these changes
Mar 13, 2023
| text-decoration: none; | ||
| } | ||
| .btn-link { | ||
| &:extend(.icon-link); |
Contributor
There was a problem hiding this comment.
As long as .btn-link still has the underline, this is exactly the change I was hoping for!
Member
Author
There was a problem hiding this comment.
It does indeed, so I think we're good to go. Thanks for the review!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to recent discussion on #2699, here's some added button styling for another link that needs it.