Skip to content

Improve button styling in critical fix page. #2741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
demiankatz merged 2 commits into from
Mar 13, 2023
Merged

Improve button styling in critical fix page. #2741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9210437
Improve button styling in critical fix page.
demiankatz Mar 6, 2023
d518140
No underline on buttons.
demiankatz Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion themes/bootprint3/css/compiled.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion themes/bootstrap3/css/compiled.css
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions themes/bootstrap3/less/bootstrap.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ label { cursor: pointer; }
.icon-bar { background-color: #888; }

// Icons vs. Underline fix
.btn {
text-decoration: none;
}
.btn-link {
&:extend(.icon-link);
Copy link
Copy Markdown
Contributor

@crhallberg crhallberg Mar 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as .btn-link still has the underline, this is exactly the change I was hoping for!

Copy link
Copy Markdown
Member Author

@demiankatz demiankatz Mar 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does indeed, so I think we're good to go. Thanks for the review!


Expand Down
3 changes: 3 additions & 0 deletions themes/bootstrap3/scss/bootstrap.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ label { cursor: pointer; }
.icon-bar { background-color: #888; }

// Icons vs. Underline fix
.btn {
text-decoration: none;
}
.btn-link {
@extend .icon-link;

Expand Down
2 changes: 1 addition & 1 deletion themes/bootstrap3/templates/upgrade/criticalfixinsecuredatabase.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@

<p><b>STRONGLY RECOMMENDED:</b> You can fix the problem by visiting the <a href="<?=$this->url('install-fixsecurity')?>">Fix Security</a> page. You should return to the Upgrade page after completing this task.</p>

<p>Alternatively, you can choose to <a href="<?=$this->url('upgrade-criticalfixinsecuredatabase')?>?ignore=true">ignore the problem</a>.</p>
<p>Alternatively, you can choose to <a class="btn btn-default" href="<?=$this->url('upgrade-criticalfixinsecuredatabase')?>?ignore=true">ignore the problem</a>.</p>

2 changes: 1 addition & 1 deletion themes/local_theme_example/css/compiled.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion themes/sandal/css/compiled.css
View file
Open in desktop

Large diffs are not rendered by default.