Remove unused folder_id field from search table#2699
Conversation
|
@EreMaijala, I think this is more or less ready to go. The screen for selecting whether or not to remove the deprecated column in the upgrade process could probably be beautified, but at least it's functional. Maybe @crhallberg has some ideas there. |
EreMaijala
left a comment
EreMaijala
left a comment
There was a problem hiding this comment.
Looks good to me and works as well!
|
Thanks, @EreMaijala! Here's a screen shot of the new upgrade screen in case @crhallberg wants to suggest any changes to confirmdeprecatedcolumns.phtml before I merge this PR:
|
|
|
||
| <p><b>RECOMMENDED:</b> You can <a href="<?=$this->url('upgrade-confirmdeprecatedcolumns')?>?action=delete">remove the columns</a>.</p> | ||
|
|
||
| <p>Alternatively, if you are using these columns for some reason (e.g. in local custom code), you can choose to <a href="<?=$this->url('upgrade-confirmdeprecatedcolumns')?>?action=keep">keep the columns</a>.</p> |
There was a problem hiding this comment.
As regular link, it looks like it will take you to documentation on how to do this. I would instead style these links as buttons by adding the classes btn btn-default.
There was a problem hiding this comment.
Thanks, @crhallberg. I had to use btn btn-default btn-link to avoid having underlines inside the buttons. Is that appropriate, or should I do things differently? (If I leave off btn-default they don't look like buttons).
There was a problem hiding this comment.
That makes sense, I'm surprised that .btn-default doesn't remove the underline. That might be a more consistent option.
There was a problem hiding this comment.
Please take a look at my latest changes to #2741. If you approve of that approach, I can update this to match once it is merged.
There was a problem hiding this comment.
Okay, @crhallberg, #2741 has been merged into this, and I've adjusted the template accordingly. I think this is ready to merge now; just needs your approval.
3 participants
The search table in the database has contained a folder_id field since the early days of VuFind 1.x; however, this field has never been used for anything. This PR removes the unused field and associated code/indexes.
TODO