Skip to content

Add per-step snapshots and PartOfPlan relation for motion plans#840

Merged
Marcus (sucrammal) merged 1 commit into
mainfrom
motion-plan-replayer-1c-snapshots
Jul 20, 2026
Merged

Add per-step snapshots and PartOfPlan relation for motion plans#840
Marcus (sucrammal) merged 1 commit into
mainfrom
motion-plan-replayer-1c-snapshots

Conversation

@sucrammal

@sucrammal Marcus (sucrammal) commented Jul 10, 2026

Copy link
Copy Markdown
Member

With frame descriptors in place, the replayer needs a renderable snapshot per trajectory step and a way to group a plan's spawned entities for teardown. Adds parsedPlanToSnapshots (ParsedPlan â Snapshot[]) and the PartOfPlan ECS relation (autoDestroy: 'source') so destroying a plan entity cascades to its members.

Changes

  • Frontend: Adds plan-to-snapshots.ts building one Snapshot of proto Transforms per step, and relations.ts defining PartOfPlan
  • Tests: Adds plan-to-snapshots.spec.ts (one snapshot per step, per-frame transforms, jointed pose baking) and relations.spec.ts (cascade destroy)

Stack

Links

Testing

  • Run npx vitest run src/lib/plugins/MotionPlanReplayer/tests/plan-to-snapshots.spec.ts â¦/relations.spec.ts
  • Confirm N trajectory steps produce N snapshots and destroying the plan root removes all PartOfPlan members

Stack created with GitHub Stacks CLIGive Feedback 💬

@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-07-20 14:36 UTC

@changeset-bot

changeset-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a96cb53

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@viamrobotics/motion-tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@changeset-bot

changeset-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8c9d6d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@viamrobotics/motion-tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sucrammal
Marcus (sucrammal) force-pushed the motion-plan-replayer-1b-descriptors branch from db39be3 to c9ac8ba Compare July 13, 2026 19:50
@sucrammal
Marcus (sucrammal) force-pushed the motion-plan-replayer-1c-snapshots branch 3 times, most recently from 7e5f113 to ec8a6bf Compare July 13, 2026 21:17
@sucrammal
Marcus (sucrammal) force-pushed the motion-plan-replayer-1c-snapshots branch from ec8a6bf to 0df4412 Compare July 14, 2026 16:20
@viam-overwatch

Copy link
Copy Markdown

Hey Marcus (@sucrammal) — this PR has been approved and CI has been green for 3+ business days. Ready to merge?

Auto-comment from overwatch. Will not re-nudge for 7 days.

@sucrammal
Marcus (sucrammal) force-pushed the motion-plan-replayer-1c-snapshots branch from 0df4412 to 8304379 Compare July 20, 2026 14:17
@sucrammal
Marcus (sucrammal) force-pushed the motion-plan-replayer-1b-descriptors branch 2 times, most recently from 46a4d48 to 60f5ce8 Compare July 20, 2026 14:24
@sucrammal
Marcus (sucrammal) force-pushed the motion-plan-replayer-1c-snapshots branch from 8304379 to 147b3d4 Compare July 20, 2026 14:24
Base automatically changed from motion-plan-replayer-1b-descriptors to main July 20, 2026 14:30
@sucrammal
Marcus (sucrammal) force-pushed the motion-plan-replayer-1c-snapshots branch from 147b3d4 to a96cb53 Compare July 20, 2026 14:30
@sucrammal
Marcus (sucrammal) merged commit 0f42c63 into main Jul 20, 2026
7 checks passed
@sucrammal
Marcus (sucrammal) deleted the motion-plan-replayer-1c-snapshots branch July 20, 2026 14:35
@claude claude Bot mentioned this pull request Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants