Add per-step snapshots and PartOfPlan relation for motion plans#840
Merged
Conversation
Contributor
|
This was referenced Jul 10, 2026
Marcus (sucrammal)
marked this pull request as ready for review
July 13, 2026 15:02
Marcus (sucrammal)
force-pushed
the
motion-plan-replayer-1c-snapshots
branch
from
July 13, 2026 15:57
79c0ef9 to
8c9d6d7
Compare
Marcus (sucrammal)
force-pushed
the
motion-plan-replayer-1b-descriptors
branch
from
July 13, 2026 15:57
0dd3002 to
db39be3
Compare
🦋 Changeset detectedLatest commit: a96cb53 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🦋 Changeset detectedLatest commit: 8c9d6d7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Matthew MacFarquhar (mattmacf98)
approved these changes
Jul 13, 2026
Marcus (sucrammal)
force-pushed
the
motion-plan-replayer-1b-descriptors
branch
from
July 13, 2026 19:50
db39be3 to
c9ac8ba
Compare
Marcus (sucrammal)
force-pushed
the
motion-plan-replayer-1c-snapshots
branch
3 times, most recently
from
July 13, 2026 21:17
7e5f113 to
ec8a6bf
Compare
Devin T. Currie (DTCurrie)
approved these changes
Jul 14, 2026
Marcus (sucrammal)
force-pushed
the
motion-plan-replayer-1c-snapshots
branch
from
July 14, 2026 16:20
ec8a6bf to
0df4412
Compare
|
Hey Marcus (@sucrammal) — this PR has been approved and CI has been green for 3+ business days. Ready to merge? Auto-comment from overwatch. Will not re-nudge for 7 days. |
Marcus (sucrammal)
force-pushed
the
motion-plan-replayer-1c-snapshots
branch
from
July 20, 2026 14:17
0df4412 to
8304379
Compare
Marcus (sucrammal)
force-pushed
the
motion-plan-replayer-1b-descriptors
branch
2 times, most recently
from
July 20, 2026 14:24
46a4d48 to
60f5ce8
Compare
Marcus (sucrammal)
force-pushed
the
motion-plan-replayer-1c-snapshots
branch
from
July 20, 2026 14:24
8304379 to
147b3d4
Compare
Marcus (sucrammal)
force-pushed
the
motion-plan-replayer-1c-snapshots
branch
from
July 20, 2026 14:30
147b3d4 to
a96cb53
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With frame descriptors in place, the replayer needs a renderable snapshot per trajectory step and a way to group a plan's spawned entities for teardown. Adds parsedPlanToSnapshots (ParsedPlan â Snapshot[]) and the PartOfPlan ECS relation (autoDestroy: 'source') so destroying a plan entity cascades to its members.
Changes
Stack
Links
Testing
Stack created with GitHub Stacks CLI • Give Feedback 💬