Skip to content

Add frame-descriptor derivation for motion plans#839

Draft
Marcus (sucrammal) wants to merge 1 commit into
motion-plan-replayer-1a-parsefrom
motion-plan-replayer-1b-descriptors
Draft

Add frame-descriptor derivation for motion plans#839
Marcus (sucrammal) wants to merge 1 commit into
motion-plan-replayer-1a-parsefrom
motion-plan-replayer-1b-descriptors

Conversation

@sucrammal

@sucrammal Marcus (sucrammal) commented Jul 10, 2026

Copy link
Copy Markdown
Member

Rendering a plan step requires each frame resolved to a concrete transform, but a ParsedPlan only carries raw frame/orientation/geometry JSON. Adds buildFrameDescriptors, converting a ParsedPlan into static and jointed FrameDescriptors â geometry, orientation conversion (quaternion/euler/orientation-vector), joint-index mapping, and end-effector reparenting.

Changes

  • Frontend: Adds build-frame-descriptors.ts (StaticFrameDescriptor / JointFrameDescriptor / FrameDescriptor) and plan-uuid.ts (stable 16-byte ids for transforms)
  • Tests: Adds build-frame-descriptors.spec.ts covering static vs jointed frames, all three orientation encodings, geometry translation, model-frame parenting, and - OV/end-effector remapping

Stack

Links

  • APP-9316

Testing

  • Run npx vitest run src/lib/plugins/MotionPlanReplayer/tests/build-frame-descriptors.spec.ts
  • Confirm descriptors carry the correct parent, pose, and joint indices for each fixture

Stack created with GitHub Stacks CLIGive Feedback 💬

@changeset-bot

changeset-bot Bot commented Jul 10, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0dd3002

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@viamrobotics/motion-tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://viamrobotics.github.io/visualization/pr-preview/pr-839/

Built to branch gh-pages at 2026-07-10 18:55 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant