refactor!: remove unsafe impl Send and Sync on NewWindowOpener#1736
Merged
Conversation
Contributor
Package Changes Through 67761c5There are 1 changes which include wry with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Legend-Master
previously approved these changes
May 24, 2026
Legend-Master
changed the title
NewWindowOpener
Legend-Master
approved these changes
May 25, 2026
Contributor
Legend-Master
left a comment
Legend-Master
left a comment
There was a problem hiding this comment.
Will wait a bit before merging at the next minor window
This was referenced May 27, 2026
Legend-Master
added a commit
that referenced
this pull request
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially superseding #1571, I'll take another look at that PR shortly, hadn't seen it no longer applies cleanly.
When we backtracked on the handler needing to be Send/Sync,
NewWindowOpenercan now also lose its unsafe override.