Skip to content

Revert moved package to MainPipe in #1736#1741

Merged
Legend-Master merged 2 commits into
tauri-apps:devfrom
sftse:fix-pr-1736
May 29, 2026
Merged

Revert moved package to MainPipe in #1736#1741
Legend-Master merged 2 commits into
tauri-apps:devfrom
sftse:fix-pr-1736

Conversation

@sftse
Copy link
Copy Markdown
Contributor

@sftse sftse commented May 29, 2026

_Originally posted by @Legend-Master in #1739 (comment)

This partially reverts commit 145b36f (#1736).

wryCreate is called before android_setup right now and the change was causing the app to crash

@Legend-Master
If there's an issue with a PR of mine, might be best to ping me in an issue so the turnaround time for a review is short.

Basically resubmitting #1739 (closes #1739)

RFR

@sftse sftse requested a review from a team as a code owner May 29, 2026 14:45
@FabianLars
Copy link
Copy Markdown
Member

Are you by any chance active on Discord and want to join our server? On a related note, want to join the working group? (That currently somewhat requires joining the discord but i'm sure we can make an exception if needed)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 29, 2026

Package Changes Through ab80ba7

There are 1 changes which include wry with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
wry 0.55.1 0.56.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@Legend-Master
Copy link
Copy Markdown
Contributor

If there's an issue with a PR of mine, might be best to ping me in an issue so the turnaround time for a review is short.

I thought directly getting a PR up and pinging you would be faster? Anyways, either PR gets merged works for me

@sftse
Copy link
Copy Markdown
Contributor Author

sftse commented May 29, 2026

If there's an issue with a PR of mine, might be best to ping me in an issue so the turnaround time for a review is short.

I thought directly getting a PR up and pinging you would be faster? Anyways, either PR gets merged works for me

Ah, sorry, I thought you're waiting on a review by a Tauri team member to merge yours.

@Legend-Master
Copy link
Copy Markdown
Contributor

Legend-Master commented May 29, 2026

I thought you're waiting on a review by a Tauri team member to merge yours.

Well, that's also true, I believe we can get someone to rubber stamp it after your acknowledgement though

(I get what you mean now, I can approve your PR so it gets merged sooner. I think that can be fixed in the future by getting you into the working group 😂)

@Legend-Master Legend-Master changed the title partial revert of 145b36f in #1736 Revert moved package to MainPipe in #1736 May 29, 2026
@Legend-Master Legend-Master merged commit b054d0e into tauri-apps:dev May 29, 2026
20 checks passed
@sftse sftse deleted the fix-pr-1736 branch May 29, 2026 16:45
@sftse
Copy link
Copy Markdown
Contributor Author

sftse commented May 29, 2026

Are you by any chance active on Discord and want to join our server? On a related note, want to join the working group? (That currently somewhat requires joining the discord but i'm sure we can make an exception if needed)

If you're willing to make an exception, I'd be happy to join. I don't believe my work significantly intersects or impedes that of others.

Open to upgrading to Discord if that turns out to be helpful in the future.

@FabianLars
Copy link
Copy Markdown
Member

Are you reachable under the email address you use to sign your commits? I think some non-github communication channel just in case would still be good.

I've just invited you to the github org just now. welcome and thank you for your contributions so far!

@sftse
Copy link
Copy Markdown
Contributor Author

sftse commented Jun 1, 2026

@FabianLars
Should I be able to approve and merge PRs with my current permissions?

@FabianLars
Copy link
Copy Markdown
Member

Not sure, I couldn't set your permissions before you accepted the invite. I'm on vacation right now so it may take a day or two for me to take a look.

@FabianLars
Copy link
Copy Markdown
Member

i just added you to the 3 main teams, feel like we should re-work our permissions/teams in the future but for now you just have access to everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants