Revert moved package to MainPipe in #1736#1739
Closed
Legend-Master wants to merge 3 commits into
Closed
Conversation
…er` (tauri-apps#1736)" This reverts commit 145b36f.
Contributor
Package Changes Through 60e1468There are 1 changes which include wry with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Contributor
Author
|
cc @sftse |
Contributor
|
Unfortunate. Is there a way we can refactor the statics so the initialization order is clearer, and how best to cover this with a test? |
Contributor
Author
|
I'm not entirely sure, it seems like the order will depends on the user of wry. I do really want to setup tests though just not sure how |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partially reverts commit 145b36f (#1736).
wryCreateis called beforeandroid_setupright now and the change was causing the app to crash