Fix C++ testing tutorial: comment out placeholder target_link_libraries > Cpp Testing #2833#6766
Merged
fujitatomoya merged 4 commits intoMay 15, 2026
Conversation
Collaborator
|
Note backport to all downstream branches. |
ahcorde
added
the
backport-all
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
fujitatomoya
approved these changes
May 15, 2026
This was referenced May 15, 2026
ahcorde
added a commit
that referenced
this pull request
May 15, 2026
…es > Cpp Testing #2833 (#6766) (#6781) (cherry picked from commit a1c1d3e) Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Deep Kotadiya <110234271+deep-zspace@users.noreply.github.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
ahcorde
added a commit
that referenced
this pull request
May 15, 2026
…es > Cpp Testing #2833 (#6766) (#6782) (cherry picked from commit a1c1d3e) Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Deep Kotadiya <110234271+deep-zspace@users.noreply.github.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CMakeLists.txtsnippet in the C++ testing tutorial includestarget_link_libraries(${PROJECT_NAME}_tutorial_test name_of_local_library).name_of_local_libraryis a placeholder, so a literal copy-paste of the snippet fails to build (CMake can't find a target by that name).Fixes # (issue)
Fixes ros2/lyrical_tutorial_party#2833
Did you use Generative AI?
yes, Claude
Additional Information
cc @kscottz