Skip to content

Fix C++ testing tutorial: comment out placeholder target_link_libraries > Cpp Testing #2833 (backport #6766)#6783

Merged
ahcorde merged 2 commits into
jazzyfrom
mergify/bp/jazzy/pr-6766
May 15, 2026
Merged

Fix C++ testing tutorial: comment out placeholder target_link_libraries > Cpp Testing #2833 (backport #6766)#6783
ahcorde merged 2 commits into
jazzyfrom
mergify/bp/jazzy/pr-6766

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented May 15, 2026

Description

  • The CMakeLists.txt snippet in the C++ testing tutorial includes target_link_libraries(${PROJECT_NAME}_tutorial_test name_of_local_library). name_of_local_library is a placeholder, so a literal copy-paste of the snippet fails to build (CMake can't find a target by that name).
  • This PR comments the line out and adds one sentence below the code block explaining that it's optional

Fixes # (issue)
Fixes ros2/lyrical_tutorial_party#2833

Did you use Generative AI?

yes, Claude

Additional Information

cc @kscottz


This is an automatic backport of pull request #6766 done by Mergify.

…es > Cpp Testing #2833 (#6766)

* Fix C++ testing tutorial: comment out placeholder target_link_libraries > Cpp Testing #2833

* Update source/Tutorials/Intermediate/Testing/Cpp.rst

Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>

---------

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit a1c1d3e)

# Conflicts:
#	source/Tutorials/Intermediate/Testing/Cpp.rst
@mergify mergify Bot added the conflicts label May 15, 2026
@mergify
Copy link
Copy Markdown
Contributor Author

mergify Bot commented May 15, 2026

Cherry-pick of a1c1d3e has failed:

On branch mergify/bp/jazzy/pr-6766
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit a1c1d3e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   source/Tutorials/Intermediate/Testing/Cpp.rst

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 15, 2026

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/25926324685/artifacts/7020683506.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-6783/index.html in your favorite browser

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde ahcorde merged commit 98ead99 into jazzy May 15, 2026
7 checks passed
@ahcorde ahcorde deleted the mergify/bp/jazzy/pr-6766 branch May 15, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants