Revert "Decouple rosout publisher init from node init. (#351)"#352
Merged
JanStaschulat merged 1 commit intoMay 2, 2023
Merged
Conversation
This reverts commit b507003. Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
Author
|
@JanStaschulat sorry about the confusion. i think we need to revert this since #351 depends on ros2/rcl#1065 after ros2/rcl#1065 is merged, we need to revert this PR again. |
Codecov Report
@@ Coverage Diff @@
## master #352 +/- ##
==========================================
+ Coverage 68.96% 69.06% +0.09%
==========================================
Files 16 16
Lines 2723 2715 -8
Branches 770 765 -5
==========================================
- Hits 1878 1875 -3
+ Misses 456 452 -4
+ Partials 389 388 -1
|
Contributor
|
okay, no problem. |
JanStaschulat
approved these changes
May 2, 2023
JanStaschulat
left a comment
JanStaschulat
left a comment
Contributor
There was a problem hiding this comment.
reverting the previous commit LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit b507003.