Revert "Revert "Decouple rosout publisher init from node init. (#351)…#353
Closed
fujitatomoya wants to merge 1 commit into
Closed
Conversation
Contributor
|
LGTM, waiting until pre-conditions are satisfied. |
fujitatomoya
commented
May 3, 2023
fujitatomoya
left a comment
fujitatomoya
left a comment
Author
There was a problem hiding this comment.
@JanStaschulat thanks for review, and sorry for the confusion. i will let you know when it is ready to merge.
iuhilnehc-ynos
approved these changes
Jun 16, 2023
fujitatomoya
force-pushed
the
revert-revert-bugfix-20230427-rclcpp-issue-2147
branch
from
daae63d to
34d50f9
Compare
Author
|
CI:
|
Contributor
|
The failed test cases of the Linux CI job are not related to rclc. For example: |
Author
|
@JanStaschulat thanks for checking on this. all related PRs are almost ready, I will let you know once ros2/rcl#1065 (comment) goes green. |
Author
|
CI(rclc for Linux): all green but windows above
|
fujitatomoya
force-pushed
the
revert-revert-bugfix-20230427-rclcpp-issue-2147
branch
from
34d50f9 to
06d8f87
Compare
Author
|
I will go ahead to close this one, and reopen targeted to rolling branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…" (#352)"
This reverts commit 2648503.
depends on ros2/rcl#1065 (please keep this open until ros2/rcl#1065 is merged.)
address ros2/rclcpp#2147