Skip to content

feat(audio): use cosmic-settings-daemon varlink interface#1352

Open
mmstick wants to merge 2 commits into
masterfrom
varlink
Open

feat(audio): use cosmic-settings-daemon varlink interface#1352
mmstick wants to merge 2 commits into
masterfrom
varlink

Conversation

@mmstick
Copy link
Copy Markdown
Member

@mmstick mmstick commented Mar 14, 2026

Must be merged and tested alongside pop-os/cosmic-settings-daemon#135

The audio applet previously connected directly to pipewire with a crate that it shared with cosmic-settings, and that contains quite a few issues that the settings-daemon implementation has resolved.


  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

@mmstick mmstick requested review from a team March 17, 2026 14:40
@mmstick mmstick marked this pull request as ready for review March 17, 2026 14:40
wash2
wash2 previously approved these changes Apr 9, 2026
@jacobgkau
Copy link
Copy Markdown
Member

This branch has conflicts.

* Query and configure audio devices using the
  `com.system76.CosmicSettings.Audio` interfaces on the
  `com.system76.CosmicSettings` varlink API
* Drops conflicting shared logic from cosmic-settings
  * and the direct pipewire dependencies that this used
* Fixes various device and route configuration quirks caused by the
  applet attempting to automatically set routes and defaults on startup
  and volume change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants