Skip to content

fix(applet-audio): prevent accidental mute on scroll from uninitialized state#1368

Closed
lincolnthalles wants to merge 2 commits into
pop-os:masterfrom
lincolnthalles:fix/audio-scroll-mute-clean
Closed

fix(applet-audio): prevent accidental mute on scroll from uninitialized state#1368
lincolnthalles wants to merge 2 commits into
pop-os:masterfrom
lincolnthalles:fix/audio-scroll-mute-clean

Conversation

@lincolnthalles
Copy link
Copy Markdown

  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

The issue is easy to replicate:

  • Run
    killall cosmic-panel
    
  • Hover the volume icon on the panel and scroll down. It will mute the audio regardless of the previous volume level due to an uninitialized state.

Closes #1215

@mmstick mmstick closed this Mar 31, 2026
@mmstick
Copy link
Copy Markdown
Member

mmstick commented Mar 31, 2026

Conflicts with #1352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scrolling on system tray volume icon set volume to zero

2 participants