feat(audio): use cosmic-settings-daemon varlink interface #1352
Annotations
10 warnings
|
Run actions-rs-plus/clippy-check@v2:
cosmic-applet-audio/src/mouse_area.rs#L354
warning: this `if` statement can be collapsed
--> cosmic-applet-audio/src/mouse_area.rs:354:5
|
354 | / if let Some(message) = widget.on_right_press.as_ref() {
355 | | if let Event::Mouse(mouse::Event::ButtonPressed(mouse::Button::Right)) = event {
356 | | shell.publish(message.clone());
357 | | shell.capture_event();
... |
360 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_if
help: collapse nested if block
|
354 ~ if let Some(message) = widget.on_right_press.as_ref()
355 ~ && let Event::Mouse(mouse::Event::ButtonPressed(mouse::Button::Right)) = event {
356 | shell.publish(message.clone());
357 | shell.capture_event();
358 | return;
359 ~ }
|
|
|
Run actions-rs-plus/clippy-check@v2:
cosmic-applet-audio/src/mouse_area.rs#L343
warning: this `if` statement can be collapsed
--> cosmic-applet-audio/src/mouse_area.rs:343:5
|
343 | / if let Some(message) = widget.on_release.as_ref() {
344 | | if let Event::Mouse(mouse::Event::ButtonReleased(mouse::Button::Left))
345 | | | Event::Touch(touch::Event::FingerLifted { .. }) = event
... |
352 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_if
help: collapse nested if block
|
343 ~ if let Some(message) = widget.on_release.as_ref()
344 ~ && let Event::Mouse(mouse::Event::ButtonReleased(mouse::Button::Left))
345 | | Event::Touch(touch::Event::FingerLifted { .. }) = event
...
350 | return;
351 ~ }
|
|
|
Run actions-rs-plus/clippy-check@v2:
cosmic-applet-audio/src/mouse_area.rs#L332
warning: this `if` statement can be collapsed
--> cosmic-applet-audio/src/mouse_area.rs:332:5
|
332 | / if let Some(message) = widget.on_press.as_ref() {
333 | | if let Event::Mouse(mouse::Event::ButtonPressed(mouse::Button::Left))
334 | | | Event::Touch(touch::Event::FingerPressed { .. }) = event
... |
341 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_if
help: collapse nested if block
|
332 ~ if let Some(message) = widget.on_press.as_ref()
333 ~ && let Event::Mouse(mouse::Event::ButtonPressed(mouse::Button::Left))
334 | | Event::Touch(touch::Event::FingerPressed { .. }) = event
...
339 | return;
340 ~ }
|
|
|
Run actions-rs-plus/clippy-check@v2:
cosmic-applet-audio/src/mouse_area.rs#L312
warning: this `if` statement can be collapsed
--> cosmic-applet-audio/src/mouse_area.rs:312:13
|
312 | / if widget
313 | | .on_mouse_enter
314 | | .as_ref()
315 | | .or(widget.on_mouse_exit.as_ref())
... |
326 | | }
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_if
help: collapse nested if block
|
316 ~ .is_some()
317 ~ && let Event::Mouse(mouse::Event::CursorMoved { .. }) = event {
318 | state.is_out_of_bounds = true;
...
323 | return;
324 ~ }
|
|
|
Run actions-rs-plus/clippy-check@v2:
cosmic-applet-audio/src/mouse_area.rs#L311
warning: this `if` statement can be collapsed
--> cosmic-applet-audio/src/mouse_area.rs:311:9
|
311 | / if !state.is_out_of_bounds {
312 | | if widget
313 | | .on_mouse_enter
314 | | .as_ref()
... |
327 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_if
= note: `#[warn(clippy::collapsible_if)]` on by default
help: collapse nested if block
|
311 ~ if !state.is_out_of_bounds
312 ~ && widget
313 | .on_mouse_enter
...
325 | }
326 ~ }
|
|
|
Run actions-rs-plus/clippy-check@v2:
cosmic-applet-audio/src/mouse_area.rs#L424
warning: unneeded `return` statement
--> cosmic-applet-audio/src/mouse_area.rs:424:13
|
424 | return;
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
423 - shell.capture_event();
424 - return;
423 + shell.capture_event();
|
|
|
Run actions-rs-plus/clippy-check@v2:
cosmic-applet-audio/src/mouse_area.rs#L208
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> cosmic-applet-audio/src/mouse_area.rs:208:13
|
208 | &event,
| ^^^^^^ help: change this to: `event`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_borrow
|
|
Run actions-rs-plus/clippy-check@v2:
cosmic-applet-audio/src/mouse_area.rs#L194
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> cosmic-applet-audio/src/mouse_area.rs:194:13
|
194 | &event,
| ^^^^^^ help: change this to: `event`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
Run actions-rs-plus/clippy-check@v2:
cosmic-applet-bluetooth/src/bluetooth.rs#L153
warning: unreachable pattern
--> cosmic-applet-bluetooth/src/bluetooth.rs:153:25
|
153 | _ => return,
| ^ no value can reach this
|
note: multiple earlier patterns match some of the same values
--> cosmic-applet-bluetooth/src/bluetooth.rs:153:25
|
137 | BluerSessionEvent::ChangesProcessed(state) => {
| ------------------------------------------ matches some of the same values
...
141 | / BluerSessionEvent::RequestResponse {
142 | | req,
143 | | state,
144 | | err_msg,
145 | | } => BluerEvent::RequestResponse {
| |_________________________- matches some of the same values
...
151 | BluerSessionEvent::AgentEvent(e) => BluerEvent::AgentEvent(e),
| -------------------------------- matches some of the same values
152 |
153 | _ => return,
| ^ collectively making this unreachable
= note: `#[warn(unreachable_patterns)]` (part of `#[warn(unused)]`) on by default
|
|
Run actions-rs-plus/clippy-check@v2:
cosmic-applet-bluetooth/src/app.rs#L27
warning: unused import: `sync::LazyLock`
--> cosmic-applet-bluetooth/src/app.rs:27:33
|
27 | use std::{collections::HashMap, sync::LazyLock, time::Duration};
| ^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
|
background
wait
wait-all
cancel
Loading