Publish release archives to GitHub Releases with SHA-512 siblings#5233
Merged
Conversation
Mirrors the flow corral and ponyup recently adopted: in addition to pushing archives to Cloudsmith, each platform job now attaches its archive and a `.sha512` sibling to the tag's GitHub Release. Consumers get an integrity artifact without an extra API round-trip. The empty Release is created in pre-artefact-creation so the 13 platform jobs run in parallel against a pre-existing Release. The announce workflow's publish-release-notes-to-github step later fills in the body without replacing the assets. release-bot-action bumps from 0.6.5 to 0.6.6 repo-wide for the new create-empty-github-release entrypoint.
ponylang-main
added
the
discuss during sync
SeanTAllen
added a commit
to ponylang/changelog-tool
that referenced
this pull request
Apr 15, 2026
Text mode on Windows translates '\n' to '\r\n', which would produce CRLF-terminated siblings for Windows-built archives while Linux/macOS produce LF. Future consumers (ponyup discussion #405) byte-compare the file, so the asymmetry is a latent portability bug. changelog-tool has no Windows release jobs today, so this is defensive; applied for consistency with the same script duplicated across corral, ponyup, and ponyc (ponylang/ponyc#5233) pending centralization.
SeanTAllen
added a commit
to ponylang/corral
that referenced
this pull request
Apr 15, 2026
…l output Python text mode on Windows translates '\n' to '\r\n' on write, which would yield CRLF-terminated siblings for Windows archives while Linux/macOS produce LF. Consumers byte-compare the file, so the asymmetry is a latent portability bug. Mirrors ponylang/ponyc#5233.
SeanTAllen
added a commit
to ponylang/changelog-tool
that referenced
this pull request
Apr 15, 2026
Text mode on Windows translates '\n' to '\r\n', which would produce CRLF-terminated siblings for Windows-built archives while Linux/macOS produce LF. Future consumers (ponyup discussion #405) byte-compare the file, so the asymmetry is a latent portability bug. changelog-tool has no Windows release jobs today, so this is defensive; applied for consistency with the same script duplicated across corral, ponyup, and ponyc (ponylang/ponyc#5233) pending centralization.
SeanTAllen
added a commit
to ponylang/corral
that referenced
this pull request
Apr 15, 2026
…l output (#317) Python text mode on Windows translates '\n' to '\r\n' on write, which would yield CRLF-terminated siblings for Windows archives while Linux/macOS produce LF. Consumers byte-compare the file, so the asymmetry is a latent portability bug. Mirrors ponylang/ponyc#5233.
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors the release flow corral and ponyup recently adopted: each platform job now attaches its archive plus a
.sha512sibling to the tag's GitHub Release, in addition to pushing to Cloudsmith. Consumers get an integrity artifact without an extra API round-trip.The empty Release is created in
pre-artefact-creationso the 13 platform jobs upload into a pre-existing Release in parallel.publish-release-notes-to-githublater fills the body without replacing the assets.release-bot-actionis bumped from 0.6.5 to 0.6.6 repo-wide (to pick up the newcreate-empty-github-releaseentrypoint).Divergences from the plan
github_release.pydocstring says "ponyc" instead of the verbatim "corral" from the source file. One-word accuracy delta.write_sha512_siblingwrites in binary mode, diverging from corral/ponyup. On Windows, text mode translates\nto\r\nand would produce Windows archives with CRLF-terminated siblings while Linux/macOS produce LF. No current consumer byte-parses the sibling, so nothing is visibly broken today — but ponyup discussion Ponyc can build with VS2015 #405's migration will rely on these files, so fix now rather than on first failure. Follow-up: upstream the fix to corral and ponyup.Validation
actionlintpasses on all four modified workflow files.write_sha512_siblinglocally: byte-identical tohashlib.sha512hex + LF./usr/bin/python3is present in all 9 Linux builder images (5 x86-64 natively, 4 arm64 via qemu-user): ubuntu22.04, ubuntu24.04 (both archs), alpine 3.21/3.22/3.23 (both archs).Known operational caveats
X.Y.Ztag re-runs every platform job. Whether Cloudsmith accepts a duplicate--versionpush idempotently is unverified. If it rejects duplicates, the replay path is to rungithub_release.py uploadlocally for the affected archive.create-empty-github-release,publish-release-notes-to-githubasset preservation, and Cloudsmith's duplicate-push semantics are first truly exercised by the next real release.