Write SHA-512 sibling in binary mode for cross-platform byte-identical output#317
Merged
Merged
Conversation
…l output Python text mode on Windows translates '\n' to '\r\n' on write, which would yield CRLF-terminated siblings for Windows archives while Linux/macOS produce LF. Consumers byte-compare the file, so the asymmetry is a latent portability bug. Mirrors ponylang/ponyc#5233.
ponylang-main
added
the
discuss during sync
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python's default text mode on Windows translates
\nto\r\non write, so Windows-built archives would get CRLF-terminated.sha512siblings while Linux and macOS produce LF. The file is meant to be the byte sequence<hex>\nand future consumers (see ponylang/ponyup#405) will byte-compare, so the asymmetry is a latent portability bug.Switches to binary mode with explicit ASCII bytes and adds a short comment explaining why.
Defensive for corral specifically (no Windows release job today), but applied for cross-repo consistency — the same script is duplicated across corral, ponyup, ponyc, and changelog-tool pending centralization. Mirrors the fix in ponylang/ponyc#5233.