Write .sha512 siblings in binary mode for cross-platform parity#131
Merged
Conversation
Text mode on Windows translates '\n' to '\r\n', which would produce CRLF-terminated siblings for Windows-built archives while Linux/macOS produce LF. Future consumers (ponyup discussion #405) byte-compare the file, so the asymmetry is a latent portability bug. changelog-tool has no Windows release jobs today, so this is defensive; applied for consistency with the same script duplicated across corral, ponyup, and ponyc (ponylang/ponyc#5233) pending centralization.
ponylang-main
added
the
discuss during sync
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python text mode on Windows translates
\nto\r\n, so Windows-built archives would get CRLF-terminated.sha512siblings while Linux/macOS produce LF. Future consumers (see ponyup discussion #405) byte-compare the file, so the asymmetry is a latent portability bug.changelog-tool has no Windows release jobs today, so this is defensive. Applied for consistency with the same script duplicated across corral, ponyup, and ponyc (ponylang/ponyc#5233) pending centralization.
Smoke-tested locally: output is
<hex>\n(129 bytes), byte-identical tohashlib.sha512(archive_bytes).hexdigest() + '\n'encoded as ascii, LF-only with no CR.