Repository navigation
fix: reuse packaged wheels for notice metadata - #250
Merged
Merged
Conversation
sodle-splunk
marked this pull request as ready for review
July 18, 2026 17:43
This was referenced Jul 19, 2026
Prefer connector-bundled wheels during pip fallback so legacy native dependencies are not rebuilt from source in the notice hook. References PAPP-38222 and PAPP-38246. Written by Codex.
sodle-splunk
force-pushed
the
sodle/notice-include-system-packages
branch
from
July 20, 2026 19:48
9ed7374 to
9a62177
Compare
sodle-splunk
changed the title
This was referenced Jul 20, 2026
phantom-jacob
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The NOTICE hook's pip fallback rebuilt connector requirements from package indexes instead of preferring the compatible wheels already packaged by the connector. Kafka and Microsoft SCCM therefore attempted to rebuild legacy Kerberos dependencies under Python 3.13 even though both connectors already ship compatible wheels.
MISP was removed from this change after tracing its packaged setuptools dependency to an obsolete PyMISP/jsonschema chain; that dependency is being corrected in the connector instead.
Why this belongs in the NOTICE hook
Kafka and Microsoft SCCM require native Kerberos modules at runtime, rather than carrying obsolete build-only dependencies:
gssapi. The current upstream release still publishes no Linux wheel and requires system GSSAPI/Kerberos headers when built from source.pykerberos. Its latest upstream release is source-only.Both connectors already package compatible Linux wheels for their supported Python runtimes. Adding
--find-linksdirectives to each connector'srequirements.txtwas tested successfully in clean linux/amd64 Python 3.9 and 3.13 containers, so a connector-local workaround is possible. It would, however, duplicate interpreter-specific packaging knowledge in every connector that ships native wheels.The NOTICE fallback owns the temporary dependency installation and already receives the connector path. Having it prefer the connector's canonical wheel directories keeps NOTICE metadata aligned with the artifacts actually shipped and fixes the behavior once for native-wheel connectors without changing their runtime dependency declarations.
Tracking
Changes
--find-linksbefore installing NOTICE dependenciesVerification
Written by Codex.
Fresh connector confirmation
Codex reran the hosted pre-commit jobs after the shared runner repair. Kafka, Microsoft SCCM, and Microsoft Windows Remote Management all still fail in the same NOTICE fallback while installing their shipped native Kerberos requirements; their compile checks pass. This also blocks PAPP-38250 / splunk-soar-connectors/microsoftwindowsremotemanagement#63.
Written by Codex.