Skip to content

fix: improve MISP validation and data handling - #37

Merged
phantom-jacob merged 8 commits into
mainfrom
sodle/espm-5228-misp-security-fixes
Jul 29, 2026
Merged

phantom-jacob merged 8 commits into
mainfrom
sodle/espm-5228-misp-security-fixes

Conversation

@sodle-splunk

@sodle-splunk sodle-splunk commented Jul 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • verify MISP server certificates by default
  • bound run query pagination and reject zero maximum results
  • attach malware sample bytes with sanitized file names
  • fail tag updates when PyMISP reports in-body errors
  • report event lookup failures as action errors
  • upgrade PyMISP and remove obsolete packaged dependencies, including setuptools

Tracking

  • PAPP-38251
  • PSAAS-30844
  • PSAAS-32047
  • PSAAS-32100
  • PSAAS-32305
  • PSAAS-32312
  • Parent epic: ESPM-5228

Quality gate

  • local pre-commit: passed
  • hosted pre-commit: passed
  • hosted compile: passed
  • integration setup: passed; remaining shared-infrastructure checks are non-blocking

Written by Codex.

Release impact

This PR contains a breaking configuration change and must ship as a major release. MISP now verifies server certificates by default; existing assets must trust the server certificate chain or explicitly disable verification. The corresponding functional commit includes a parseable BREAKING CHANGE: trailer for semantic-release.

Merge strategy: merge commit only; do not squash

Release-impact note added by Codex.

Written by Codex.

BREAKING CHANGE: MISP now verifies server certificates by default; existing assets must trust the server certificate chain or explicitly disable verification.
@github-actions

github-actions Bot commented Jul 19, 2026 •

Copy link
Copy Markdown

Merging this PR will release 3.0.0 with the following release notes:

3.0.0 (2026-07-29)

Connector release changes

  • Verify MISP server certificates by default.
  • Bound run query pagination and reject zero maximum results.
  • Attach downloaded malware sample bytes with sanitized file names.
  • Fail tag updates when PyMISP reports an in-body error.
  • Report MISP event lookup failures as action errors.

Upgrade PyMISP to remove its legacy jsonschema dependency and stop bundling setuptools and the associated unused transitive packages.

References PAPP-38251. Written by Codex.
@sodle-splunk
sodle-splunk marked this pull request as ready for review July 20, 2026 19:52
@sodle-splunk sodle-splunk changed the title fix: remediate MISP security findings fix: improve MISP validation and data handling Jul 24, 2026
@sodle-splunk
sodle-splunk force-pushed the sodle/espm-5228-misp-security-fixes branch from adf4e18 to fc88828 Compare July 29, 2026 17:07
@sodle-splunk

Copy link
Copy Markdown
Contributor Author

Codex breaking-change review: this PR needs to be redone as a breaking/major release before merge.

Reason: it changes verify_server_cert default/fallback from false to true. Under the updated connector release guidance, changing secure transport/config defaults in a way that can make existing assets fail where they previously succeeded is a breaking change. If the secure default is intentional, please preserve it but add major-release treatment: a parseable BREAKING CHANGE: trailer (or equivalent breaking Conventional Commit), release notes that call out the behavior change and migration impact, and any required PR description updates. If this should remain a non-major release, preserve the previous runtime default instead and document the opt-in secure setting.

Commented by Codex.

Pin the packaged wrapt dependency so dependency generation remains reproducible when upstream releases change.

Authored by Codex.
@phantom-jacob
phantom-jacob merged commit 8e2c0ec into main Jul 29, 2026
23 of 32 checks passed
@phantom-jacob
phantom-jacob deleted the sodle/espm-5228-misp-security-fixes branch July 29, 2026 21:35
@splunk-soar-semantic-release

Copy link
Copy Markdown

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants