Repository navigation
fix: improve WinRM validation and data handling - #63
Conversation
Written by Codex.
Addresses PSAAS-30809 and PSAAS-31340. Written by Codex. BREAKING CHANGE: WinRM now defaults to HTTPS on port 5986 with certificate verification; existing assets must provide a compatible trusted listener or explicitly override these settings.
Written by Codex.
Written by Codex.
Written by Codex.
Written by Codex.
|
Merging this PR will release 3.0.0 (2026-07-29)Connector release changes
|
Use dev-cicd-tools v2.2.8, which reuses packaged native wheels during NOTICE generation. Written by Codex.
fa0efc1 to
da0e759
Compare
|
Codex breaking-change review: this PR needs to be redone as a breaking/major release before merge. Reason: it changes Commented by Codex. |
phantom-jacob
left a comment
There was a problem hiding this comment.
Fresh review completed against the unchanged current head. The connector changes, release notes, commit history, and required pre-commit, compile, build, and coverage gates are acceptable. The stale or malformed PR description is non-blocking per the review direction.
Approved by Codex.
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary\n\n- quote and escape copy/delete PowerShell path arguments\n- default assets to certificate-validated WinRM over HTTPS\n- reject oversized AppLocker XML and document type declarations\n- report nonzero run command and run script exit codes as failures\n\n## Tracking\n\n- PAPP-38250\n- PSAAS-30809\n- PSAAS-31000\n- PSAAS-31340\n- PSAAS-32165\n- PSAAS-32241\n- Parent epic: ESPM-5228\n\n## Quality gate\n\n- compile: passed locally\n- connector lint, format, static analysis, docs, and static tests: passed locally\n- macOS-only local linter cannot install the connector's Linux pykerberos wheel\n- hosted Linux NOTICE generation is blocked on https://github.com/phantomcyber/dev-cicd-tools/pull/250\n\nThis PR remains draft until the shared NOTICE fix is released and hosted pre-commit plus compile pass.\n\nWritten by Codex.
Tracking
Merge strategy: merge commit only; do not squash.
Written by Codex.
Release impact
This PR contains a breaking configuration change and must ship as a major release. WinRM now defaults to HTTPS on port 5986 with certificate verification; existing assets must provide a compatible trusted listener or explicitly override these settings. The corresponding functional commit includes a parseable
BREAKING CHANGE:trailer for semantic-release.Release-impact note added by Codex.