Skip to content

Use pandacan package for panda#38074

Open
premkiran2 wants to merge 2 commits into
commaai:masterfrom
premkiran2:proper-pip-package-validation
Open

Use pandacan package for panda#38074
premkiran2 wants to merge 2 commits into
commaai:masterfrom
premkiran2:proper-pip-package-validation

Conversation

@premkiran2
Copy link
Copy Markdown

Validation PR for removing panda as an openpilot submodule and consuming it as a normal Python dependency.

This PR:

  • removes the panda submodule entry from .gitmodules
  • removes the panda gitlink
  • replaces direct panda transport deps with pandacan from premkiran2/panda@proper-pip-package
  • updates SConstruct to locate the installed panda package and run its packaged SConscript with a local variant_dir

Depends on panda package PR: commaai/panda#2403

Local validation:

  • python3 -m py_compile SConstruct
  • parsed pyproject.toml dependencies
  • git diff --cached --check before commit

Full CI on this PR is the intended validation that openpilot can build without the panda submodule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant