Include firmware and build files in pandacan package#2403
Closed
premkiran2 wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pandacan currently installs the Python API and a couple of headers, but downstream users need a more complete package to use panda without a git submodule.
This PR updates the package so prepared wheels include the signed firmware, bootstubs, packet headers, board source/build files, certs, and libpanda build files. It also moves the Linux SPI transport dependency into pandacan so consumers do not need to declare panda internals directly.
Validation:
.venv/bin/ruff check .PATH=$PWD/.venv/bin:$PATH .venv/bin/pytestPATH=$PWD/.venv/bin:$PATH .venv/bin/sconspandacan-0.0.11wheel and verified required firmware/build files plusspidevmetadata are presentOpenpilot validation PR: commaai/openpilot#38074