cockpit-ci: Update container to 2026-05-16; Use cockpit.location.go() for URL-based container switching#2541
Conversation
e350b0d to
e112808
Compare
|
The firefox failure reproduces effortlessly with
The critical step is in line 842. With the new firefox this triggers a page reload, which resets the expanded state of "Images". I'll push a fix, but looking at the other tests still. |
|
This affects more tests. Editing the URL in the interactive browser does not reload the page. Our I noticed that we call
This isn't something that a user could ever do interactively, and is cheating. Instead of fixing/replacing def go(self, url_hash: str) -> None:
with self.driver.restore_context():
self.switch_to_top()
self.call_js_func('ph_go', url_hash)This passes This phenomenon also explains this kind of failure in cockpit-project/cockpit#23277 -- the unexpected page load causes the "ph_texts not defined" error, as at that point we don't wait for a page load. So let's instead try to fix |
e112808 to
6c3b96f
Compare
|
Still several test failures now. But we really need to fix these screenshots, they are absolutely useless when they happen after cleanup. Update: fixed in #2547 |
|
The TestApplication.testRunImageUser failure reproduces locally, and it's 100% stable. Once again, clicking on the container link in the images table with firefox reloads the page. The browser bug is well known by now, it updates the URL to add an anchor |
This will pick up the Firefox hack for <https://bugzilla.mozilla.org/show_bug.cgi?id=2018546>, i.e. avoids a page reload when clicking on the "Used by:" links. (This wasn't a test issue -- human clicks did the same.) `cockpit.location.go()` adds an extra `/` after the hash. Adjust the consumer and test accordingly.
6c3b96f to
b707d4f
Compare
Uh oh!
There was an error while loading. Please reload this page.