Skip to content

cockpit-ci: Update container to 2026-05-16; Use cockpit.location.go() for URL-based container switching #2541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jelly merged 2 commits into from
May 21, 2026
Merged

cockpit-ci: Update container to 2026-05-16; Use cockpit.location.go() for URL-based container switching #2541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24e41d9
Use cockpit.location.go() for URL-based container switching
martinpitt May 20, 2026
b707d4f
cockpit-ci: Update container to 2026-05-16
cockpituous May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .cockpit-ci/container
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
ghcr.io/cockpit-project/tasks:2026-03-14
ghcr.io/cockpit-project/tasks:2026-05-16
2 changes: 1 addition & 1 deletion src/Containers.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,7 +551,7 @@ class Containers extends React.Component {
return {
expandedContent: <ListingPanel colSpan='4' tabRenderers={tabs} />,
columns,
initiallyExpanded: document.location.hash.substring(1) === container.Id,
initiallyExpanded: document.location.hash.substring(2) === container.Id,
props: {
key: container.key,
"data-row-id": container.key,
Expand Down
3 changes: 1 addition & 2 deletions src/ImageUsedBy.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ const ImageUsedBy = ({ containers, showAll }) => {
<Button variant="link"
isInline
onClick={() => {
const loc = document.location.toString().split('#')[0];
document.location = `${loc}#${container.Id}`;
cockpit.location.go('#' + container.Id);

if (!isRunning)
showAll();
Expand Down
4 changes: 2 additions & 2 deletions test/check-application
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2365,7 +2365,7 @@ Yaml={name}.yaml
b.click(f'{container_sel} td.pf-v6-c-table__toggle button')
# running container, just selects it, but leaves "Only running" alone
b.click(f"{container_sel} + tr div.ct-listing-panel-body button:contains('busybox-with-tty')")
b.wait_js_cond('window.location.hash === "#' + id_with_tty + '"')
b.wait_js_cond('window.location.hash === "#/' + id_with_tty + '"')
b.wait_val("#containers-containers-filter", "running")
# FIXME: expanding running container details does not actually work right now
# b.wait_in_text("#containers-containers tr.pf-m-expanded .container-details", "sleep infinity")
Expand All @@ -2392,7 +2392,7 @@ Yaml={name}.yaml
b.wait_not_in_text("#containers-containers", "busybox-not-started")
container_sel = f"{self.getImageSelector(IMG_BUSYBOX_LATEST, system=auth)} + tr div.ct-listing-panel-body"
b.click(f"{container_sel} button:contains('busybox-not-started')")
b.wait_js_cond(f"window.location.hash === '#{sha}'")
b.wait_js_cond(f"window.location.hash === '#/{sha}'")
b.wait_val("#containers-containers-filter", "all")
b.wait_in_text("#containers-containers", "busybox-not-started")
# auto-expands container details
Expand Down