test: Fix test failure artifacts#2547
Draft
martinpitt wants to merge 1 commit into
Draft
Conversation
Commit 15c0741 broke failure screenshots/HTML dumps: It *first* logged out of the session and shut it down, and *then* called the parent tearDown() which does the artifact dumping. That made the artifacts always show the login page, and thus useless.
martinpitt
requested review from
jelly and
tomasmatus
and removed request for
jelly and
tomasmatus
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 15c0741 broke failure screenshots/HTML dumps: It first logged out of the session and shut it down, and then called the parent tearDown() which does the artifact dumping. That made the artifacts always show the login page, and thus useless.
See e.g. this failure from #2541. I ran this locally, and
TestApplication-testRunImageUser-fedora-44-127.0.0.2-2201-FAIL.pngis correct again.