Add type hints to blueman.plugins - #1338
Merged
Merged
Conversation
cschramm
force-pushed
the
types-plugins
branch
6 times, most recently
from
August 16, 2020 07:58
c46879b to
ad653df
Compare
cschramm
force-pushed
the
types-plugins
branch
from
August 18, 2020 07:01
ad653df to
19c1e4d
Compare
Merged
cschramm
force-pushed
the
types-plugins
branch
from
August 18, 2020 20:17
19c1e4d to
fbc8640
Compare
cschramm
marked this pull request as ready for review
August 18, 2020 20:41
cschramm
force-pushed
the
types-plugins
branch
from
August 18, 2020 22:31
fbc8640 to
b706930
Compare
cschramm
force-pushed
the
types-plugins
branch
2 times, most recently
from
August 19, 2020 10:14
2540ce3 to
521f790
Compare
infirit
reviewed
Aug 19, 2020
infirit
left a comment
infirit
left a comment
Contributor
There was a problem hiding this comment.
I skimmed through this and I am really curious what will happen when we proper typehints are available for pygobject :-).
cschramm
force-pushed
the
types-plugins
branch
from
August 19, 2020 22:39
521f790 to
80a2d96
Compare
A GSourceFunc as passed to g_timeout_add is expected to return a boolean. Returning None works fine as PyGObject uses PyObject_IsTrue to convert whatever python object it gets, so that it returns FALSE / G_SOURCE_REMOVE.
* FORCE_HIDE was never actually used, so an indication whether or not to force-show the icon is sufficient. * BluemanApplet.Manager is always initialized since bd63d53.
...to AppletPlugin and ManagerPlugin. It is specific to those types and the base class does not have to know anything about it.
Services.on_request_menu_items.add_menu_item expects every Service class to implement them (which is the fact, just not expressed).
The monitor class is always the same
cschramm
force-pushed
the
types-plugins
branch
from
August 19, 2020 22:47
80a2d96 to
4ded76a
Compare
infirit
approved these changes
Aug 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1332